Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update screenshot in readme #5452

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Update screenshot in readme #5452

merged 2 commits into from
Jan 11, 2023

Conversation

kolibril13
Copy link
Contributor

In the readme, there is currently a picture showing an astronaut in the napari viewer, but the script generates cells in 3d.
Therefore, I've changed the image to a screenshot that I get when I run the example script in the latest napari version.
I've used the GitHub markdown drag and drop to add this image, so this image lives in the GitHub image database, and does not live in this repo. This might be a good idea, as the screenshot does not use repo space that way.
The outdated screenshot got originally readded in #5220

@codecov
Copy link

codecov bot commented Dec 29, 2022 •
edited
Loading

Codecov Report

Merging #5452 (8c28642) into main (562cc7f) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 8c28642 differs from pull request most recent head 68a7f52. Consider uploading reports for the commit 68a7f52 to get more accurate results

@@           Coverage Diff           @@
##             main    #5452   +/-   ##
=======================================
  Coverage   89.22%   89.23%           
=======================================
  Files         599      599           
  Lines       50884    50884           
=======================================
+ Hits        45400    45405    +5     
+ Misses       5484     5479    -5
Impacted Files Coverage Δ
napari/_qt/dialogs/qt_package_installer.py 81.67% <0.00%> (+0.39%) ⬆️
napari/utils/theme.py 92.85% <0.00%> (+0.59%) ⬆️
napari/utils/info.py 81.44% <0.00%> (+1.03%) ⬆️
napari/_qt/__init__.py 56.66% <0.00%> (+6.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Carreau
Carreau reviewed Jan 4, 2023
View reviewed changes
README.md Outdated
@@ -47,7 +47,8 @@ import napari
viewer = napari.view_image(data.cells3d(), channel_axis=1, ndisplay=3)
```

![napari viewer showing an image of an astronaut.](https://github.com/napari/docs/blob/main/docs/images/screenshot-add-image.png)
<img width="1198" alt="napari viewer showing cells in 3d." src="https://user-images.githubusercontent.com/44469195/209934762-aba0c2c0-5829-43ac-96f1-ce55707860b4.png">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There does not seem to be anything else except this that link to githubusercontent, I don't have any particular preference, but I want to make sure other are Ok with that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other option would be to link to the docs repo?
https://github.com/napari/docs/blob/d1c287825d065a3d7511979f97f9194d63d6da7d/docs/images/multichannel_cells.png

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's the image used in napari.org
https://napari.org

psobolewskiPhD
psobolewskiPhD requested changes Jan 9, 2023
View reviewed changes
Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hasty. I prefer doing back to the cells image, but I think we should use the actual image from the napari/docs repo, as @jni requested in the other PR that was merged and went back to astronaut.
So just replace screenshot-add-image.png with multichannel_cells.png

Also, we should correct, not drop, the alt text. I suggest using that also from the other repo:

![napari viewer with a multichannel image of cells displayed as two image layers: nuclei and membrane.]

psobolewskiPhD
psobolewskiPhD reviewed Jan 9, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@kolibril13 @psobolewskiPhD
Update README.md
68a7f52 
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
@psobolewskiPhD
Copy link
Member

Tests must be un-related, I'l re-run

@GenevieveBuckley
Copy link
Contributor

I'm +1 @psobolewskiPhD

@psobolewskiPhD psobolewskiPhD merged commit ed26f41 into napari:main Jan 11, 2023
@Czaki Czaki mentioned this pull request Jun 7, 2023
Closed
@Czaki Czaki added this to the 0.4.18 milestone Jun 13, 2023
@Czaki Czaki added maintenance PR with maintance changes, triaged-0.4.18 To mark PR that is triaged in 0.4.18 release process labels Jun 13, 2023
Czaki pushed a commit that referenced this pull request Jun 16, 2023
@kolibril13 @psobolewskiPhD @Czaki
Update screenshot in readme (#5452)
c08c949 
* Update README.md

* Update README.md

Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>

Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Czaki pushed a commit that referenced this pull request Jun 17, 2023
@kolibril13 @psobolewskiPhD @Czaki
Update screenshot in readme (#5452)
0d1af92 
* Update README.md

* Update README.md

Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>

Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Czaki pushed a commit that referenced this pull request Jun 18, 2023
@kolibril13 @psobolewskiPhD @Czaki
Update screenshot in readme (#5452)
b68c4b1 
* Update README.md

* Update README.md

Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>

Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Czaki pushed a commit that referenced this pull request Jun 19, 2023
@kolibril13 @psobolewskiPhD @Czaki
Update screenshot in readme (#5452)
8dc4561 
* Update README.md

* Update README.md

Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>

Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Czaki pushed a commit that referenced this pull request Jun 21, 2023
@kolibril13 @psobolewskiPhD @Czaki
Update screenshot in readme (#5452)
585d26e 
* Update README.md

* Update README.md

Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>

Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Czaki pushed a commit that referenced this pull request Jun 21, 2023
@kolibril13 @psobolewskiPhD @Czaki
Update screenshot in readme (#5452)
8ae44f6 
* Update README.md

* Update README.md

Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>

Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Czaki pushed a commit that referenced this pull request Jun 21, 2023
@kolibril13 @psobolewskiPhD @Czaki
Update screenshot in readme (#5452)
c3419d9 
* Update README.md

* Update README.md

Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>

Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carreau Carreau Carreau left review comments

@jni jni jni approved these changes

@psobolewskiPhD psobolewskiPhD psobolewskiPhD approved these changes

@GenevieveBuckley GenevieveBuckley Awaiting requested review from GenevieveBuckley

Assignees

@kolibril13 kolibril13

Labels
maintenance PR with maintance changes, triaged-0.4.18 To mark PR that is triaged in 0.4.18 release process
Projects
None yet
Milestone
0.4.18
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kolibril13 @psobolewskiPhD @GenevieveBuckley @Carreau @jni @Czaki