Bugfix: POLL_INTERVAL_MS used in QTimer needs to be an int on python 3.10 #5467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Czaki
approved these changes
Jan 11, 2023
Codecov Report
@@ Coverage Diff @@
## main #5467 +/- ##
==========================================
- Coverage 89.29% 89.27% -0.03%
==========================================
Files 600 600
Lines 50964 50964
==========================================
- Hits 45510 45499 -11
- Misses 5454 5465 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
goanpeca
approved these changes
Jan 11, 2023
Czaki
added
the
triaged-0.4.18
Czaki
pushed a commit
that referenced
this pull request
Jun 16, 2023
…3.10 (#5467) # Description Python 3.10 no longer casts floats to ints python/cpython#82180 The variable `POLL_INTERVAL_MS` is used by QTimer and the `setInterval()` needs an int (in milliseconds), see: https://doc.qt.io/qt-5/qtimer.html This means that in python 3.10 the existing value (16.666) results in a TypeError (see #5415 ) and napari doesn't even launch. Note: This is part of the experimental async/octree and apparently not tested on 3.10 CI. `POLL_INTERVAL_MS` is fairly arbitrary and unused anywhere else, so in this PR I simply assign an int to it, `16` rather than the `16.666` (~1/60). ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # References Closes #5415 # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [ ] example: the test suite for my feature covers cases x, y, and z - [ ] example: all tests pass with my change - [x] example: If I enable the experimental features in settings, then napari won't launch on main (as in the issue) but will launch with this branch. ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If I included new strings, I have used `trans.` to make them localizable. For more information see our [translations guide](https://napari.org/developers/translations.html).
Czaki
pushed a commit
that referenced
this pull request
Jun 17, 2023
…3.10 (#5467) # Description Python 3.10 no longer casts floats to ints python/cpython#82180 The variable `POLL_INTERVAL_MS` is used by QTimer and the `setInterval()` needs an int (in milliseconds), see: https://doc.qt.io/qt-5/qtimer.html This means that in python 3.10 the existing value (16.666) results in a TypeError (see #5415 ) and napari doesn't even launch. Note: This is part of the experimental async/octree and apparently not tested on 3.10 CI. `POLL_INTERVAL_MS` is fairly arbitrary and unused anywhere else, so in this PR I simply assign an int to it, `16` rather than the `16.666` (~1/60). ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # References Closes #5415 # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [ ] example: the test suite for my feature covers cases x, y, and z - [ ] example: all tests pass with my change - [x] example: If I enable the experimental features in settings, then napari won't launch on main (as in the issue) but will launch with this branch. ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If I included new strings, I have used `trans.` to make them localizable. For more information see our [translations guide](https://napari.org/developers/translations.html).
Czaki
pushed a commit
that referenced
this pull request
Jun 18, 2023
…3.10 (#5467) # Description Python 3.10 no longer casts floats to ints python/cpython#82180 The variable `POLL_INTERVAL_MS` is used by QTimer and the `setInterval()` needs an int (in milliseconds), see: https://doc.qt.io/qt-5/qtimer.html This means that in python 3.10 the existing value (16.666) results in a TypeError (see #5415 ) and napari doesn't even launch. Note: This is part of the experimental async/octree and apparently not tested on 3.10 CI. `POLL_INTERVAL_MS` is fairly arbitrary and unused anywhere else, so in this PR I simply assign an int to it, `16` rather than the `16.666` (~1/60). ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # References Closes #5415 # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [ ] example: the test suite for my feature covers cases x, y, and z - [ ] example: all tests pass with my change - [x] example: If I enable the experimental features in settings, then napari won't launch on main (as in the issue) but will launch with this branch. ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If I included new strings, I have used `trans.` to make them localizable. For more information see our [translations guide](https://napari.org/developers/translations.html).
Czaki
pushed a commit
that referenced
this pull request
Jun 19, 2023
…3.10 (#5467) # Description Python 3.10 no longer casts floats to ints python/cpython#82180 The variable `POLL_INTERVAL_MS` is used by QTimer and the `setInterval()` needs an int (in milliseconds), see: https://doc.qt.io/qt-5/qtimer.html This means that in python 3.10 the existing value (16.666) results in a TypeError (see #5415 ) and napari doesn't even launch. Note: This is part of the experimental async/octree and apparently not tested on 3.10 CI. `POLL_INTERVAL_MS` is fairly arbitrary and unused anywhere else, so in this PR I simply assign an int to it, `16` rather than the `16.666` (~1/60). ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # References Closes #5415 # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [ ] example: the test suite for my feature covers cases x, y, and z - [ ] example: all tests pass with my change - [x] example: If I enable the experimental features in settings, then napari won't launch on main (as in the issue) but will launch with this branch. ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If I included new strings, I have used `trans.` to make them localizable. For more information see our [translations guide](https://napari.org/developers/translations.html).
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
…3.10 (#5467) # Description Python 3.10 no longer casts floats to ints python/cpython#82180 The variable `POLL_INTERVAL_MS` is used by QTimer and the `setInterval()` needs an int (in milliseconds), see: https://doc.qt.io/qt-5/qtimer.html This means that in python 3.10 the existing value (16.666) results in a TypeError (see #5415 ) and napari doesn't even launch. Note: This is part of the experimental async/octree and apparently not tested on 3.10 CI. `POLL_INTERVAL_MS` is fairly arbitrary and unused anywhere else, so in this PR I simply assign an int to it, `16` rather than the `16.666` (~1/60). ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # References Closes #5415 # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [ ] example: the test suite for my feature covers cases x, y, and z - [ ] example: all tests pass with my change - [x] example: If I enable the experimental features in settings, then napari won't launch on main (as in the issue) but will launch with this branch. ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If I included new strings, I have used `trans.` to make them localizable. For more information see our [translations guide](https://napari.org/developers/translations.html).
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
…3.10 (#5467) # Description Python 3.10 no longer casts floats to ints python/cpython#82180 The variable `POLL_INTERVAL_MS` is used by QTimer and the `setInterval()` needs an int (in milliseconds), see: https://doc.qt.io/qt-5/qtimer.html This means that in python 3.10 the existing value (16.666) results in a TypeError (see #5415 ) and napari doesn't even launch. Note: This is part of the experimental async/octree and apparently not tested on 3.10 CI. `POLL_INTERVAL_MS` is fairly arbitrary and unused anywhere else, so in this PR I simply assign an int to it, `16` rather than the `16.666` (~1/60). ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # References Closes #5415 # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [ ] example: the test suite for my feature covers cases x, y, and z - [ ] example: all tests pass with my change - [x] example: If I enable the experimental features in settings, then napari won't launch on main (as in the issue) but will launch with this branch. ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If I included new strings, I have used `trans.` to make them localizable. For more information see our [translations guide](https://napari.org/developers/translations.html).
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
…3.10 (#5467) # Description Python 3.10 no longer casts floats to ints python/cpython#82180 The variable `POLL_INTERVAL_MS` is used by QTimer and the `setInterval()` needs an int (in milliseconds), see: https://doc.qt.io/qt-5/qtimer.html This means that in python 3.10 the existing value (16.666) results in a TypeError (see #5415 ) and napari doesn't even launch. Note: This is part of the experimental async/octree and apparently not tested on 3.10 CI. `POLL_INTERVAL_MS` is fairly arbitrary and unused anywhere else, so in this PR I simply assign an int to it, `16` rather than the `16.666` (~1/60). ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update # References Closes #5415 # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [ ] example: the test suite for my feature covers cases x, y, and z - [ ] example: all tests pass with my change - [x] example: If I enable the experimental features in settings, then napari won't launch on main (as in the issue) but will launch with this branch. ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If I included new strings, I have used `trans.` to make them localizable. For more information see our [translations guide](https://napari.org/developers/translations.html).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Python 3.10 no longer casts floats to ints
python/cpython#82180
The variable
POLL_INTERVAL_MSis used by QTimer and thesetInterval()needs an int (in milliseconds), see:https://doc.qt.io/qt-5/qtimer.html
This means that in python 3.10 the existing value (16.666) results in a TypeError (see #5415 ) and napari doesn't even launch.
Note: This is part of the experimental async/octree and apparently not tested on 3.10 CI.
POLL_INTERVAL_MSis fairly arbitrary and unused anywhere else, so in this PR I simply assign an int to it,16rather than the16.666(~1/60).Type of change
References
Closes #5415
How has this been tested?
Final checklist:
trans.to make them localizable.For more information see our translations guide.