Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update conda_menu_config.json for latest fixes in menuinst #5564

Merged
merged 1 commit into from
Feb 18, 2023

Conversation

jaimergp
Copy link
Contributor

@jaimergp jaimergp commented Feb 15, 2023

Description

Comes from napari/packaging#62, where I had to introduce some changes in the menu config JSON file. I am now backporting this to the source repo so the conda-forge recipe receives these updates too.

Type of change

  • Bug-fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

References

How has this been tested?

  • The original PR is passing.

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • If I included new strings, I have used trans. to make them localizable.
    For more information see our translations guide.

@jaimergp jaimergp added the bundle An issue with the bundled executable app label Feb 15, 2023
@goanpeca
Copy link
Contributor

goanpeca commented Feb 15, 2023

thanks for working on this @jaimergp! is the dev branch of menuinst using some sort of pydantic validation we could use to just check the json is valid and remains being valid 🤔 ?

Maybe have a menuinst.api.validate method 🤷🏼

@jaimergp
Copy link
Contributor Author

It's under menuinst._schema, but in order to avoid one more dependency in conda (conda depends on menuinst), this not used at runtime. Instead it's technically done during conda-build (see the upstream summary issue for the conda-build PR). To be revisited because conda is changing some strategic points and we might see a pydantic dependency in the future anyway.

@Czaki Czaki added the ready to merge Last chance for comments! Will be merged in ~24h label Feb 17, 2023
@jni jni merged commit 8c57e3b into napari:main Feb 18, 2023
@Czaki Czaki removed the ready to merge Last chance for comments! Will be merged in ~24h label Feb 18, 2023
@Czaki Czaki mentioned this pull request Jun 7, 2023
@Czaki Czaki added this to the 0.4.18 milestone Jun 15, 2023
@Czaki Czaki added maintenance PR with maintance changes, triaged-0.4.18 To mark PR that is triaged in 0.4.18 release process labels Jun 15, 2023
Czaki pushed a commit that referenced this pull request Jun 18, 2023
Comes from napari/packaging#62, where I had to introduce some changes in the menu config JSON file. I am now backporting this to the source repo so the conda-forge recipe receives these updates too.
Czaki pushed a commit that referenced this pull request Jun 19, 2023
Comes from napari/packaging#62, where I had to introduce some changes in the menu config JSON file. I am now backporting this to the source repo so the conda-forge recipe receives these updates too.
Czaki pushed a commit that referenced this pull request Jun 21, 2023
Comes from napari/packaging#62, where I had to introduce some changes in the menu config JSON file. I am now backporting this to the source repo so the conda-forge recipe receives these updates too.
Czaki pushed a commit that referenced this pull request Jun 21, 2023
Comes from napari/packaging#62, where I had to introduce some changes in the menu config JSON file. I am now backporting this to the source repo so the conda-forge recipe receives these updates too.
Czaki pushed a commit that referenced this pull request Jun 21, 2023
Comes from napari/packaging#62, where I had to introduce some changes in the menu config JSON file. I am now backporting this to the source repo so the conda-forge recipe receives these updates too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bundle An issue with the bundled executable app maintenance PR with maintance changes, triaged-0.4.18 To mark PR that is triaged in 0.4.18 release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants