Fix vispy axes labels #5565
Merged
Fix vispy axes labels #5565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brisvag : assigning you because of your recent overlay refactor work. @psobolewskiPhD : would be great if you could also take a look and help with testing to make sure this covers all the issues you found! |
Codecov Report
@@ Coverage Diff @@
## main #5565 +/- ##
==========================================
+ Coverage 87.93% 89.43% +1.49%
==========================================
Files 609 611 +2
Lines 51238 51280 +42
==========================================
+ Hits 45055 45860 +805
+ Misses 6183 5420 -763
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
andy-sweet
commented
Feb 15, 2023
| @@ -17,7 +17,6 @@ def __init__(self, *, viewer, overlay, parent=None) -> None: | |||
| super().__init__( | |||
| node=Axes(), viewer=viewer, overlay=overlay, parent=parent | |||
| ) | |||
| self.overlay.events.visible.connect(self._on_visible_change) | |||
There was a problem hiding this comment.
This change is unrelated to the bug fix, but I picked it up along the way.
The base overlay already connects to the visible event of the overlay model. I'm not sure if the extra connection does any harm, but there's no reason for it.
psobolewskiPhD
approved these changes
Feb 16, 2023
brisvag
approved these changes
Feb 17, 2023
|
Thanks for the reviews both! I'll probably merge this shortly after the weekend unless there are any objections.
Good catch. Done. |
psobolewskiPhD
added
the
ready to merge
andy-sweet
commented
Feb 21, 2023
| @@ -311,7 +311,7 @@ def test_surface_normals(): | |||
| faces = np.array([[0, 1, 2], [3, 4, 5], [6, 7, 8]]) | |||
| values = np.array([1, 2, 3, 1, 2, 3, 1, 2, 3]) | |||
|
|
|||
| normals = dict(face=dict(visible=True, color='red')) | |||
There was a problem hiding this comment.
Not sure how that passed through, but it should be now fixed in main as well from #5575
…apari into fix-5536-axes-display-order
psobolewskiPhD
removed
the
ready to merge
|
As #4907 has the 0.4.18 milestone, this should too. |
Czaki
pushed a commit
that referenced
this pull request
Jun 18, 2023
# Description This ensures that the vispy axes overlay labels are updated when the general data of the overlay changes. One common way this happens is as a result of a change to `Dims.ndim` which may occur when layers are added or removed. I added a test to cover the bug in #5536. This relies on the same utility function I have used previously to get the vispy node scene size, so I brought that into the general test utilities. I also added a few smaller unit tests for the vispy overlay as sanity checks before I found the actual issue. ## Type of change - [x] Bug-fix (non-breaking change which fixes an issue) # References Closes #5536 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Czaki
pushed a commit
that referenced
this pull request
Jun 19, 2023
# Description This ensures that the vispy axes overlay labels are updated when the general data of the overlay changes. One common way this happens is as a result of a change to `Dims.ndim` which may occur when layers are added or removed. I added a test to cover the bug in #5536. This relies on the same utility function I have used previously to get the vispy node scene size, so I brought that into the general test utilities. I also added a few smaller unit tests for the vispy overlay as sanity checks before I found the actual issue. ## Type of change - [x] Bug-fix (non-breaking change which fixes an issue) # References Closes #5536 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
# Description This ensures that the vispy axes overlay labels are updated when the general data of the overlay changes. One common way this happens is as a result of a change to `Dims.ndim` which may occur when layers are added or removed. I added a test to cover the bug in #5536. This relies on the same utility function I have used previously to get the vispy node scene size, so I brought that into the general test utilities. I also added a few smaller unit tests for the vispy overlay as sanity checks before I found the actual issue. ## Type of change - [x] Bug-fix (non-breaking change which fixes an issue) # References Closes #5536 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
# Description This ensures that the vispy axes overlay labels are updated when the general data of the overlay changes. One common way this happens is as a result of a change to `Dims.ndim` which may occur when layers are added or removed. I added a test to cover the bug in #5536. This relies on the same utility function I have used previously to get the vispy node scene size, so I brought that into the general test utilities. I also added a few smaller unit tests for the vispy overlay as sanity checks before I found the actual issue. ## Type of change - [x] Bug-fix (non-breaking change which fixes an issue) # References Closes #5536 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
# Description This ensures that the vispy axes overlay labels are updated when the general data of the overlay changes. One common way this happens is as a result of a change to `Dims.ndim` which may occur when layers are added or removed. I added a test to cover the bug in #5536. This relies on the same utility function I have used previously to get the vispy node scene size, so I brought that into the general test utilities. I also added a few smaller unit tests for the vispy overlay as sanity checks before I found the actual issue. ## Type of change - [x] Bug-fix (non-breaking change which fixes an issue) # References Closes #5536 --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This ensures that the vispy axes overlay labels are updated when the general data of the overlay changes. One common way this happens is as a result of a change to
Dims.ndimwhich may occur when layers are added or removed.I added a test to cover the bug in #5536. This relies on the same utility function I have used previously to get the vispy node scene size, so I brought that into the general test utilities.
I also added a few smaller unit tests for the vispy overlay as sanity checks before I found the actual issue.
Type of change
References
Closes #5536