Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problem of missing plugin widgets after minimize napari #5577

Merged
merged 5 commits into from
Mar 7, 2023
Merged

Fix problem of missing plugin widgets after minimize napari #5577

merged 5 commits into from
Mar 7, 2023

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Feb 21, 2023

Description

It removes the setVisible call triggered during minimalization of napari window

Type of change

  • Bug-fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

References

closes #5576

How has this been tested?

  • example: the test suite for my feature covers cases x, y, and z
  • example: all tests pass with my change
  • example: I check if my changes works with both PySide and PyQt backends
    as there are small differences between the two Qt bindings.

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • If I included new strings, I have used trans. to make them localizable.
    For more information see our translations guide.

@ppwadhwa You add this in #3331. Maybe I missed some use case and this need to be called in some scenarios.

@github-actions github-actions bot added the qt Relates to qt label Feb 21, 2023
@github-actions github-actions bot added the tests Something related to our tests label Feb 21, 2023
@RileyMShea
Copy link

The PR seems to solve the issue for me when I test it locally.

@Czaki Czaki added the bugfix PR with bugfix label Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023 •
edited
Loading

Codecov Report

Merging #5577 (779f2b0) into main (c77e001) will increase coverage by 1.49%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5577      +/-   ##
==========================================
+ Coverage   88.02%   89.52%   +1.49%     
==========================================
  Files         610      610              
  Lines       51176    51194      +18     
==========================================
+ Hits        45050    45829     +779     
+ Misses       6126     5365     -761
Impacted Files Coverage Δ
napari/_qt/widgets/qt_viewer_dock_widget.py 96.59% <ø> (+0.54%) ⬆️
napari/_tests/utils.py 100.00% <0.00%> (ø)
napari/utils/config.py 100.00% <0.00%> (ø)
napari/layers/utils/string_encoding.py 100.00% <0.00%> (ø)
napari/components/experimental/monitor/_api.py 0.00% <0.00%> (ø)
napari/utils/_tests/test_key_bindings.py 96.96% <0.00%> (+0.01%) ⬆️
napari/layers/utils/color_encoding.py 96.20% <0.00%> (+0.04%) ⬆️
napari/layers/utils/style_encoding.py 96.22% <0.00%> (+0.07%) ⬆️
napari/layers/shapes/_tests/test_shapes_utils.py 97.22% <0.00%> (+0.07%) ⬆️
napari/_app_model/constants/_menus.py 95.45% <0.00%> (+0.21%) ⬆️
... and 48 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions github-actions bot removed the tests Something related to our tests label Feb 21, 2023
Carreau
Carreau approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@Carreau Carreau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, I'm just wondering why the call was there in the first place.

@jni jni added the ready to merge Last chance for comments! Will be merged in ~24h label Feb 22, 2023
@ppwadhwa
Copy link
Contributor

Sorry y'all, I may have just added that and never second guessed that it wasn't necessary. I see that there is a toggle function on each plugin entry, so I am not sure if I missed that before and thought I needed to hide the widget when you toggle the menu item? I can't remember.

Thanks for the fix @Czaki !

@Czaki Czaki mentioned this pull request Mar 1, 2023
Merged
9 tasks
@Czaki Czaki merged commit ff1e56e into napari:main Mar 7, 2023
@Czaki Czaki deleted the bugfix/missing_widgets branch March 7, 2023 23:14
@Czaki Czaki removed the ready to merge Last chance for comments! Will be merged in ~24h label Mar 7, 2023
brisvag pushed a commit that referenced this pull request Apr 4, 2023
@Czaki
Enable ruff rules part 4. (#5590)
4964490 
# Description
<!-- What does this pull request (PR) do? Why is it necessary? -->
<!-- Tell us about your new feature, improvement, or fix! -->
<!-- If your change includes user interface changes, please add an
image, or an animation "An image is worth a thousand words!" -->
<!-- You can use https://www.cockos.com/licecap/ or similar to create
animations -->

* `INP` flake8-no-pep420 - The pep 420 is something that part of us may
remember as the reason why napari stop working at some moment because of
some problematic files in `site-packages`.

 * `PYI` flake8-pyi - better type annotation 
* `Q`, flake8-quotes - enforce quoting, but the rule Q000 is disabled
(see #5589).
* `RSE` # flake8-raise - simplify raise code by remove `()` when
obsolete.
* `RET` # flake8-return - simplify code readability by forcing proper
return schema.
 * `TID` # flake8-tidy-imports - replacement for absolutify imports 
* `TRY` # tryceratops - enforce rules on exception raises like keeping
in try only this that could raise exception (see why it could create
problems in #5577).
* `ICN` # flake8-import-conventions - enforce import convention for
alias (like `import numpy as np`)
 * `RUF`# ruff specific rules - 

## Type of change
<!-- Please delete options that are not relevant. -->
- [x] Maintenance

# References
<!-- What resources, documentation, and guides were used in the creation
of this PR? -->
<!-- If this is a bug-fix or otherwise resolves an issue, reference it
here with "closes #(issue)" -->

# How has this been tested?
<!-- Please describe the tests that you ran to verify your changes. -->
- [ ] example: the test suite for my feature covers cases x, y, and z
- [ ] example: all tests pass with my change
- [ ] example: I check if my changes works with both PySide and PyQt
backends
      as there are small differences between the two Qt bindings.  

## Final checklist:
- [ ] My PR is the minimum possible work for the desired functionality
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] If I included new strings, I have used `trans.` to make them
localizable.
For more information see our [translations
guide](https://napari.org/developers/translations.html).
kcpevey pushed a commit to kcpevey/napari that referenced this pull request Apr 6, 2023
@Czaki @kcpevey
Enable ruff rules part 4. (napari#5590)
2c9d5fe 
<!-- What does this pull request (PR) do? Why is it necessary? -->
<!-- Tell us about your new feature, improvement, or fix! -->
<!-- If your change includes user interface changes, please add an
image, or an animation "An image is worth a thousand words!" -->
<!-- You can use https://www.cockos.com/licecap/ or similar to create
animations -->

* `INP` flake8-no-pep420 - The pep 420 is something that part of us may
remember as the reason why napari stop working at some moment because of
some problematic files in `site-packages`.

 * `PYI` flake8-pyi - better type annotation
* `Q`, flake8-quotes - enforce quoting, but the rule Q000 is disabled
(see napari#5589).
* `RSE` # flake8-raise - simplify raise code by remove `()` when
obsolete.
* `RET` # flake8-return - simplify code readability by forcing proper
return schema.
 * `TID` # flake8-tidy-imports - replacement for absolutify imports
* `TRY` # tryceratops - enforce rules on exception raises like keeping
in try only this that could raise exception (see why it could create
problems in napari#5577).
* `ICN` # flake8-import-conventions - enforce import convention for
alias (like `import numpy as np`)
 * `RUF`# ruff specific rules -

<!-- Please delete options that are not relevant. -->
- [x] Maintenance

<!-- What resources, documentation, and guides were used in the creation
of this PR? -->
<!-- If this is a bug-fix or otherwise resolves an issue, reference it
here with "closes #(issue)" -->

<!-- Please describe the tests that you ran to verify your changes. -->
- [ ] example: the test suite for my feature covers cases x, y, and z
- [ ] example: all tests pass with my change
- [ ] example: I check if my changes works with both PySide and PyQt
backends
      as there are small differences between the two Qt bindings.

- [ ] My PR is the minimum possible work for the desired functionality
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] If I included new strings, I have used `trans.` to make them
localizable.
For more information see our [translations
guide](https://napari.org/developers/translations.html).
@Czaki Czaki mentioned this pull request Jun 7, 2023
Closed
@psobolewskiPhD psobolewskiPhD added this to the 0.4.18 milestone Jun 8, 2023
@psobolewskiPhD psobolewskiPhD added the triaged-0.4.18 To mark PR that is triaged in 0.4.18 release process label Jun 8, 2023
Czaki added a commit that referenced this pull request Jun 18, 2023
@Czaki @pre-commit-ci
Fix problem of missing plugin widgets after minimize napari (#5577)
ac43ab6 
# Description
<!-- What does this pull request (PR) do? Why is it necessary? -->
<!-- Tell us about your new feature, improvement, or fix! -->
<!-- If your change includes user interface changes, please add an
image, or an animation "An image is worth a thousand words!" -->
<!-- You can use https://www.cockos.com/licecap/ or similar to create
animations -->

It removes the `setVisible` call triggered during minimalization of
napari window

## Type of change
<!-- Please delete options that are not relevant. -->
- [x] Bug-fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

# References
<!-- What resources, documentation, and guides were used in the creation
of this PR? -->
<!-- If this is a bug-fix or otherwise resolves an issue, reference it
here with "closes #(issue)" -->

closes #5576

# How has this been tested?
<!-- Please describe the tests that you ran to verify your changes. -->
- [ ] example: the test suite for my feature covers cases x, y, and z
- [ ] example: all tests pass with my change
- [ ] example: I check if my changes works with both PySide and PyQt
backends
      as there are small differences between the two Qt bindings.  

## Final checklist:
- [ ] My PR is the minimum possible work for the desired functionality
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] If I included new strings, I have used `trans.` to make them
localizable.
For more information see our [translations
guide](https://napari.org/developers/translations.html).

@ppwadhwa You add this in #3331. Maybe I missed some use case and this
need to be called in some scenarios.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Czaki added a commit that referenced this pull request Jun 19, 2023
@Czaki @pre-commit-ci
Fix problem of missing plugin widgets after minimize napari (#5577)
128a6b5 
# Description
<!-- What does this pull request (PR) do? Why is it necessary? -->
<!-- Tell us about your new feature, improvement, or fix! -->
<!-- If your change includes user interface changes, please add an
image, or an animation "An image is worth a thousand words!" -->
<!-- You can use https://www.cockos.com/licecap/ or similar to create
animations -->

It removes the `setVisible` call triggered during minimalization of
napari window

## Type of change
<!-- Please delete options that are not relevant. -->
- [x] Bug-fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

# References
<!-- What resources, documentation, and guides were used in the creation
of this PR? -->
<!-- If this is a bug-fix or otherwise resolves an issue, reference it
here with "closes #(issue)" -->

closes #5576

# How has this been tested?
<!-- Please describe the tests that you ran to verify your changes. -->
- [ ] example: the test suite for my feature covers cases x, y, and z
- [ ] example: all tests pass with my change
- [ ] example: I check if my changes works with both PySide and PyQt
backends
      as there are small differences between the two Qt bindings.  

## Final checklist:
- [ ] My PR is the minimum possible work for the desired functionality
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] If I included new strings, I have used `trans.` to make them
localizable.
For more information see our [translations
guide](https://napari.org/developers/translations.html).

@ppwadhwa You add this in #3331. Maybe I missed some use case and this
need to be called in some scenarios.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Czaki added a commit that referenced this pull request Jun 19, 2023
@Czaki
Enable ruff rules part 4. (#5590)
a3f98ba 
<!-- What does this pull request (PR) do? Why is it necessary? -->
<!-- Tell us about your new feature, improvement, or fix! -->
<!-- If your change includes user interface changes, please add an
image, or an animation "An image is worth a thousand words!" -->
<!-- You can use https://www.cockos.com/licecap/ or similar to create
animations -->

* `INP` flake8-no-pep420 - The pep 420 is something that part of us may
remember as the reason why napari stop working at some moment because of
some problematic files in `site-packages`.

 * `PYI` flake8-pyi - better type annotation
* `Q`, flake8-quotes - enforce quoting, but the rule Q000 is disabled
(see #5589).
* `RSE` # flake8-raise - simplify raise code by remove `()` when
obsolete.
* `RET` # flake8-return - simplify code readability by forcing proper
return schema.
 * `TID` # flake8-tidy-imports - replacement for absolutify imports
* `TRY` # tryceratops - enforce rules on exception raises like keeping
in try only this that could raise exception (see why it could create
problems in #5577).
* `ICN` # flake8-import-conventions - enforce import convention for
alias (like `import numpy as np`)
 * `RUF`# ruff specific rules -

<!-- Please delete options that are not relevant. -->
- [x] Maintenance

<!-- What resources, documentation, and guides were used in the creation
of this PR? -->
<!-- If this is a bug-fix or otherwise resolves an issue, reference it
here with "closes #(issue)" -->

<!-- Please describe the tests that you ran to verify your changes. -->
- [ ] example: the test suite for my feature covers cases x, y, and z
- [ ] example: all tests pass with my change
- [ ] example: I check if my changes works with both PySide and PyQt
backends
      as there are small differences between the two Qt bindings.

- [ ] My PR is the minimum possible work for the desired functionality
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] If I included new strings, I have used `trans.` to make them
localizable.
For more information see our [translations
guide](https://napari.org/developers/translations.html).
Czaki added a commit that referenced this pull request Jun 21, 2023
@Czaki @pre-commit-ci
Fix problem of missing plugin widgets after minimize napari (#5577)
bd272f1 
# Description
<!-- What does this pull request (PR) do? Why is it necessary? -->
<!-- Tell us about your new feature, improvement, or fix! -->
<!-- If your change includes user interface changes, please add an
image, or an animation "An image is worth a thousand words!" -->
<!-- You can use https://www.cockos.com/licecap/ or similar to create
animations -->

It removes the `setVisible` call triggered during minimalization of
napari window

## Type of change
<!-- Please delete options that are not relevant. -->
- [x] Bug-fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

# References
<!-- What resources, documentation, and guides were used in the creation
of this PR? -->
<!-- If this is a bug-fix or otherwise resolves an issue, reference it
here with "closes #(issue)" -->

closes #5576

# How has this been tested?
<!-- Please describe the tests that you ran to verify your changes. -->
- [ ] example: the test suite for my feature covers cases x, y, and z
- [ ] example: all tests pass with my change
- [ ] example: I check if my changes works with both PySide and PyQt
backends
      as there are small differences between the two Qt bindings.  

## Final checklist:
- [ ] My PR is the minimum possible work for the desired functionality
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] If I included new strings, I have used `trans.` to make them
localizable.
For more information see our [translations
guide](https://napari.org/developers/translations.html).

@ppwadhwa You add this in #3331. Maybe I missed some use case and this
need to be called in some scenarios.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Czaki added a commit that referenced this pull request Jun 21, 2023
@Czaki
Enable ruff rules part 4. (#5590)
7749ebe 
<!-- What does this pull request (PR) do? Why is it necessary? -->
<!-- Tell us about your new feature, improvement, or fix! -->
<!-- If your change includes user interface changes, please add an
image, or an animation "An image is worth a thousand words!" -->
<!-- You can use https://www.cockos.com/licecap/ or similar to create
animations -->

* `INP` flake8-no-pep420 - The pep 420 is something that part of us may
remember as the reason why napari stop working at some moment because of
some problematic files in `site-packages`.

 * `PYI` flake8-pyi - better type annotation
* `Q`, flake8-quotes - enforce quoting, but the rule Q000 is disabled
(see #5589).
* `RSE` # flake8-raise - simplify raise code by remove `()` when
obsolete.
* `RET` # flake8-return - simplify code readability by forcing proper
return schema.
 * `TID` # flake8-tidy-imports - replacement for absolutify imports
* `TRY` # tryceratops - enforce rules on exception raises like keeping
in try only this that could raise exception (see why it could create
problems in #5577).
* `ICN` # flake8-import-conventions - enforce import convention for
alias (like `import numpy as np`)
 * `RUF`# ruff specific rules -

<!-- Please delete options that are not relevant. -->
- [x] Maintenance

<!-- What resources, documentation, and guides were used in the creation
of this PR? -->
<!-- If this is a bug-fix or otherwise resolves an issue, reference it
here with "closes #(issue)" -->

<!-- Please describe the tests that you ran to verify your changes. -->
- [ ] example: the test suite for my feature covers cases x, y, and z
- [ ] example: all tests pass with my change
- [ ] example: I check if my changes works with both PySide and PyQt
backends
      as there are small differences between the two Qt bindings.

- [ ] My PR is the minimum possible work for the desired functionality
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] If I included new strings, I have used `trans.` to make them
localizable.
For more information see our [translations
guide](https://napari.org/developers/translations.html).
Czaki added a commit that referenced this pull request Jun 21, 2023
@Czaki @pre-commit-ci
Fix problem of missing plugin widgets after minimize napari (#5577)
3c1a834 
# Description
<!-- What does this pull request (PR) do? Why is it necessary? -->
<!-- Tell us about your new feature, improvement, or fix! -->
<!-- If your change includes user interface changes, please add an
image, or an animation "An image is worth a thousand words!" -->
<!-- You can use https://www.cockos.com/licecap/ or similar to create
animations -->

It removes the `setVisible` call triggered during minimalization of
napari window

## Type of change
<!-- Please delete options that are not relevant. -->
- [x] Bug-fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

# References
<!-- What resources, documentation, and guides were used in the creation
of this PR? -->
<!-- If this is a bug-fix or otherwise resolves an issue, reference it
here with "closes #(issue)" -->

closes #5576

# How has this been tested?
<!-- Please describe the tests that you ran to verify your changes. -->
- [ ] example: the test suite for my feature covers cases x, y, and z
- [ ] example: all tests pass with my change
- [ ] example: I check if my changes works with both PySide and PyQt
backends
      as there are small differences between the two Qt bindings.  

## Final checklist:
- [ ] My PR is the minimum possible work for the desired functionality
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] If I included new strings, I have used `trans.` to make them
localizable.
For more information see our [translations
guide](https://napari.org/developers/translations.html).

@ppwadhwa You add this in #3331. Maybe I missed some use case and this
need to be called in some scenarios.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Czaki added a commit that referenced this pull request Jun 21, 2023
@Czaki
Enable ruff rules part 4. (#5590)
e6a9de7 
<!-- What does this pull request (PR) do? Why is it necessary? -->
<!-- Tell us about your new feature, improvement, or fix! -->
<!-- If your change includes user interface changes, please add an
image, or an animation "An image is worth a thousand words!" -->
<!-- You can use https://www.cockos.com/licecap/ or similar to create
animations -->

* `INP` flake8-no-pep420 - The pep 420 is something that part of us may
remember as the reason why napari stop working at some moment because of
some problematic files in `site-packages`.

 * `PYI` flake8-pyi - better type annotation
* `Q`, flake8-quotes - enforce quoting, but the rule Q000 is disabled
(see #5589).
* `RSE` # flake8-raise - simplify raise code by remove `()` when
obsolete.
* `RET` # flake8-return - simplify code readability by forcing proper
return schema.
 * `TID` # flake8-tidy-imports - replacement for absolutify imports
* `TRY` # tryceratops - enforce rules on exception raises like keeping
in try only this that could raise exception (see why it could create
problems in #5577).
* `ICN` # flake8-import-conventions - enforce import convention for
alias (like `import numpy as np`)
 * `RUF`# ruff specific rules -

<!-- Please delete options that are not relevant. -->
- [x] Maintenance

<!-- What resources, documentation, and guides were used in the creation
of this PR? -->
<!-- If this is a bug-fix or otherwise resolves an issue, reference it
here with "closes #(issue)" -->

<!-- Please describe the tests that you ran to verify your changes. -->
- [ ] example: the test suite for my feature covers cases x, y, and z
- [ ] example: all tests pass with my change
- [ ] example: I check if my changes works with both PySide and PyQt
backends
      as there are small differences between the two Qt bindings.

- [ ] My PR is the minimum possible work for the desired functionality
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] If I included new strings, I have used `trans.` to make them
localizable.
For more information see our [translations
guide](https://napari.org/developers/translations.html).
Czaki added a commit that referenced this pull request Jun 21, 2023
@Czaki @pre-commit-ci
Fix problem of missing plugin widgets after minimize napari (#5577)
32ff61e 
# Description
<!-- What does this pull request (PR) do? Why is it necessary? -->
<!-- Tell us about your new feature, improvement, or fix! -->
<!-- If your change includes user interface changes, please add an
image, or an animation "An image is worth a thousand words!" -->
<!-- You can use https://www.cockos.com/licecap/ or similar to create
animations -->

It removes the `setVisible` call triggered during minimalization of
napari window

## Type of change
<!-- Please delete options that are not relevant. -->
- [x] Bug-fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

# References
<!-- What resources, documentation, and guides were used in the creation
of this PR? -->
<!-- If this is a bug-fix or otherwise resolves an issue, reference it
here with "closes #(issue)" -->

closes #5576

# How has this been tested?
<!-- Please describe the tests that you ran to verify your changes. -->
- [ ] example: the test suite for my feature covers cases x, y, and z
- [ ] example: all tests pass with my change
- [ ] example: I check if my changes works with both PySide and PyQt
backends
      as there are small differences between the two Qt bindings.  

## Final checklist:
- [ ] My PR is the minimum possible work for the desired functionality
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] If I included new strings, I have used `trans.` to make them
localizable.
For more information see our [translations
guide](https://napari.org/developers/translations.html).

@ppwadhwa You add this in #3331. Maybe I missed some use case and this
need to be called in some scenarios.

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Czaki added a commit that referenced this pull request Jun 21, 2023
@Czaki
Enable ruff rules part 4. (#5590)
f00f7f0 
<!-- What does this pull request (PR) do? Why is it necessary? -->
<!-- Tell us about your new feature, improvement, or fix! -->
<!-- If your change includes user interface changes, please add an
image, or an animation "An image is worth a thousand words!" -->
<!-- You can use https://www.cockos.com/licecap/ or similar to create
animations -->

* `INP` flake8-no-pep420 - The pep 420 is something that part of us may
remember as the reason why napari stop working at some moment because of
some problematic files in `site-packages`.

 * `PYI` flake8-pyi - better type annotation
* `Q`, flake8-quotes - enforce quoting, but the rule Q000 is disabled
(see #5589).
* `RSE` # flake8-raise - simplify raise code by remove `()` when
obsolete.
* `RET` # flake8-return - simplify code readability by forcing proper
return schema.
 * `TID` # flake8-tidy-imports - replacement for absolutify imports
* `TRY` # tryceratops - enforce rules on exception raises like keeping
in try only this that could raise exception (see why it could create
problems in #5577).
* `ICN` # flake8-import-conventions - enforce import convention for
alias (like `import numpy as np`)
 * `RUF`# ruff specific rules -

<!-- Please delete options that are not relevant. -->
- [x] Maintenance

<!-- What resources, documentation, and guides were used in the creation
of this PR? -->
<!-- If this is a bug-fix or otherwise resolves an issue, reference it
here with "closes #(issue)" -->

<!-- Please describe the tests that you ran to verify your changes. -->
- [ ] example: the test suite for my feature covers cases x, y, and z
- [ ] example: all tests pass with my change
- [ ] example: I check if my changes works with both PySide and PyQt
backends
      as there are small differences between the two Qt bindings.

- [ ] My PR is the minimum possible work for the desired functionality
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] If I included new strings, I have used `trans.` to make them
localizable.
For more information see our [translations
guide](https://napari.org/developers/translations.html).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carreau Carreau Carreau approved these changes

@jni jni jni approved these changes

Assignees

@Czaki Czaki

Labels
bugfix PR with bugfix qt Relates to qt triaged-0.4.18 To mark PR that is triaged in 0.4.18 release process
Projects
None yet
Milestone
0.4.18
Development

Successfully merging this pull request may close these issues.

Dock Widgets are hidden when restoring minimized napari
6 participants
@Czaki @RileyMShea @ppwadhwa @Carreau @jni @psobolewskiPhD