[pre-commit.ci] pre-commit autoupdate

[pre-commit-ci]

updates:

• github.com/psf/black: 23.1.0 → 23.3.0
• github.com/charliermarsh/ruff-pre-commit: v0.0.256 → v0.0.261

[codecov]

Codecov Report

Merging #5645 (558ca48) into main (e12acd8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main    #5645    +/-   ##
========================================
  Coverage   89.84%   89.84%            
========================================
  Files         608      608            
  Lines       51693    51876   +183     
========================================
+ Hits        46441    46607   +166     
- Misses       5252     5269    +17     

Impacted Files	Coverage Δ
napari/__main__.py	44.49% <ø> (ø)
napari/components/_tests/test_multichannel.py	100.00% <ø> (ø)
napari/layers/image/image.py	95.70% <ø> (-0.02%)	⬇️
napari/_app_model/context/_context.py	59.45% <100.00%> (-1.07%)	⬇️
napari/_qt/dialogs/qt_package_installer.py	87.07% <100.00%> (-0.05%)	⬇️
napari/_qt/qt_main_window.py	74.17% <100.00%> (-0.05%)	⬇️
napari/_tests/test_magicgui.py	96.65% <100.00%> (ø)
napari/_tests/test_view_layers.py	98.30% <100.00%> (-0.02%)	⬇️
...i/layers/points/_tests/test_points_key_bindings.py	100.00% <100.00%> (ø)
napari/plugins/__init__.py	94.28% <100.00%> (-0.16%)	⬇️
... and 5 more

... and 32 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[Czaki]

The fail comes from this rule: https://beta.ruff.rs/docs/rules/no-explicit-stacklevel/

[Czaki]

this changes are caused by https://beta.ruff.rs/docs/rules/#flake8-pyi-pyi PYI015 that is implementation of rule Y015 form https://pypi.org/project/flake8-pyi/

At this moment I do not understand the motivation for this change. But will try to investigate this.

But in general, I think this change should be reverted, and maybe just rules skipped.

[brisvag]

Does not seem like a bad rule to me in general, I just don't understand the fix O.o

[Czaki]

I just use implicit reexport https://mypy.readthedocs.io/en/stable/config_file.html#confval-implicit_reexport that is treated as valid by mypy so do not changed by ruff

It was also mentioned here https://scientific-python.org/specs/spec-0001/#type-checkers

It was split on multiple lines because ruff configuration combine-as-imports is set by default to false.

[jni]

Suggested change

	from napari.view_layers import (
	view_image as view_image,
	)
	from napari.view_layers import view_image

??? I don't understand this at all

[jni]

(Sorry, I missed the above links because they related to a different kind of change. But I still don't like this...)

[Czaki]

Ok. The currently this syntax is enforced by "PYI015" https://beta.ruff.rs/docs/rules/#flake8-pyi-pyi rule of ruff.
Unfortunately, this rule does not accept __all__ even when mypy accepts it.

But the current code was wrong as it does not contain explicit reexport or __all__.

I'm open to disabling "PYI015". But I also see profit from enforcing this rule. It will be nice to hear from other core devs (I will merge this PR on Sunday, but if there is no feedback immediately will open a followup).

[jni]

But I also see profit from enforcing this rule.

Such as...? 😂 I prefer __all__ by a significant margin... As in my other reviews... Code should be obvious in what it does... I suspect I would not be the first person to be totally baffled by these lines. I also think that we should combine the import lines so that we don't have so many

from X import (
    Y as Y
)

It's really quite horrible imho!

[Czaki]

Multiple import as comes from ruff configuration https://beta.ruff.rs/docs/settings/#combine-as-imports

[Czaki]

I have combined imports. I will merge in about 12h to be before the automatic update. Then I will open the Issue for a longer discussion.