Bugfix: Don't double toggle visibility for linked layers #5656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
Czaki
approved these changes
Mar 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #5656 +/- ##
==========================================
+ Coverage 88.32% 89.84% +1.51%
==========================================
Files 611 611
Lines 51541 51589 +48
==========================================
+ Hits 45524 46348 +824
+ Misses 6017 5241 -776
... and 59 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jni
approved these changes
Mar 23, 2023
psobolewskiPhD
added
the
ready to merge
psobolewskiPhD
removed
the
ready to merge
kcpevey
pushed a commit
to kcpevey/napari
that referenced
this pull request
Apr 6, 2023
Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com> # Description This PR stores the layer visibility states prior to toggling layers and then checks against it to ensure that layers are toggled relative to that initial state. This makes sure they are not double toggled if linked layers are involved. Also added a test for the interaction between linked layers and toggle_visibility that fails without this PR but now passes. ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) # References Closes napari#5655 # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [x] I added a test that fails on main but passes here - [x] all tests pass with my change ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
Czaki
added a commit
that referenced
this pull request
Jun 19, 2023
Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com> # Description This PR stores the layer visibility states prior to toggling layers and then checks against it to ensure that layers are toggled relative to that initial state. This makes sure they are not double toggled if linked layers are involved. Also added a test for the interaction between linked layers and toggle_visibility that fails without this PR but now passes. ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) # References Closes #5655 # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [x] I added a test that fails on main but passes here - [x] all tests pass with my change ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
Czaki
added a commit
that referenced
this pull request
Jun 21, 2023
Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com> # Description This PR stores the layer visibility states prior to toggling layers and then checks against it to ensure that layers are toggled relative to that initial state. This makes sure they are not double toggled if linked layers are involved. Also added a test for the interaction between linked layers and toggle_visibility that fails without this PR but now passes. ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) # References Closes #5655 # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [x] I added a test that fails on main but passes here - [x] all tests pass with my change ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
Czaki
added a commit
that referenced
this pull request
Jun 21, 2023
Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com> # Description This PR stores the layer visibility states prior to toggling layers and then checks against it to ensure that layers are toggled relative to that initial state. This makes sure they are not double toggled if linked layers are involved. Also added a test for the interaction between linked layers and toggle_visibility that fails without this PR but now passes. ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) # References Closes #5655 # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [x] I added a test that fails on main but passes here - [x] all tests pass with my change ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
Czaki
added a commit
that referenced
this pull request
Jun 21, 2023
Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com> # Description This PR stores the layer visibility states prior to toggling layers and then checks against it to ensure that layers are toggled relative to that initial state. This makes sure they are not double toggled if linked layers are involved. Also added a test for the interaction between linked layers and toggle_visibility that fails without this PR but now passes. ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) # References Closes #5655 # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [x] I added a test that fails on main but passes here - [x] all tests pass with my change ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Grzegorz Bokota bokota+github@gmail.com
Description
This PR stores the layer visibility states prior to toggling layers and then checks against it to ensure that layers are toggled relative to that initial state. This makes sure they are not double toggled if linked layers are involved.
Also added a test for the interaction between linked layers and toggle_visibility that fails without this PR but now passes.
Type of change
References
Closes #5655
How has this been tested?
as there are small differences between the two Qt bindings.
Final checklist:
trans.to make them localizable.For more information see our translations guide.