MAINT: Split test file in two to find hanging test. #5680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5680 +/- ##
==========================================
- Coverage 89.81% 89.77% -0.05%
==========================================
Files 611 612 +1
Lines 51558 51562 +4
==========================================
- Hits 46309 46291 -18
- Misses 5249 5271 +22
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
github-actions
bot
added
the
preferences
Codecov Report
@@ Coverage Diff @@
## main #5680 +/- ##
==========================================
- Coverage 89.86% 88.53% -1.33%
==========================================
Files 615 616 +1
Lines 52474 52641 +167
==========================================
- Hits 47158 46608 -550
- Misses 5316 6033 +717
|
Carreau
removed
the
preferences
|
@Carreau What did we should do here? It is ready for merge, or you would like to rerun it a few times to try to trigger the problem? |
|
I've rebased. Even if it does not fail at least that should give us a hint if it's actually here in later PRs. |
|
The longer I think about this, it looks like merge this in the main could be a good idea, but it requires to put docstring that will describe when the file was split. |
It looks like some tests in test_qt_dims do hang sometime in CI. Though it's not clear which one with Pytest output. This split the test into two file approximatively where the hang happens, so we can narrow down the problem. This may help with napari#5443 maybe ?
|
How about this ? |
Czaki
approved these changes
May 16, 2023
Czaki
removed
the
ready to merge
Czaki
added
the
triaged-0.4.18
Czaki
pushed a commit
that referenced
this pull request
Jun 19, 2023
It looks like some tests in test_qt_dims do hang sometime in CI. Though it's not clear which one with Pytest output. This split the test into two file approximatively where the hang happens, so we can narrow down the problem. This may help with #5443 maybe ?
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
It looks like some tests in test_qt_dims do hang sometime in CI. Though it's not clear which one with Pytest output. This split the test into two file approximatively where the hang happens, so we can narrow down the problem. This may help with #5443 maybe ?
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
It looks like some tests in test_qt_dims do hang sometime in CI. Though it's not clear which one with Pytest output. This split the test into two file approximatively where the hang happens, so we can narrow down the problem. This may help with #5443 maybe ?
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
It looks like some tests in test_qt_dims do hang sometime in CI. Though it's not clear which one with Pytest output. This split the test into two file approximatively where the hang happens, so we can narrow down the problem. This may help with #5443 maybe ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like some tests in test_qt_dims do hang sometime in CI. Though it's not clear which one with Pytest output.
This split the test into two file approximatively where the hang happens, so we can narrow down the problem.
This may help with #5443 maybe ?