Skip pyside6 version 6.4.3 for tests #5683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Czaki
approved these changes
Mar 29, 2023
|
I'm unsure why the PR tests are skipped and also don't know how to manually force them. Given the simplicity of the change, I think it's probably fine to merge this anyway, but if anyone knows that would be useful info! |
|
Thanks to the GitHub action fairy for starting those as they caught my mistake of skipping 6.3.4 instead of 6.4.3 as desired. |
Codecov Report
@@ Coverage Diff @@
## main #5683 +/- ##
==========================================
- Coverage 89.81% 89.79% -0.02%
==========================================
Files 611 611
Lines 51560 51640 +80
==========================================
+ Hits 46308 46371 +63
- Misses 5252 5269 +17 see 16 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I'm going to skip the usual 24 hours here to help PRs start passing again. Feel free to revert if you disagree with that. |
kcpevey
pushed a commit
to kcpevey/napari
that referenced
this pull request
Apr 6, 2023
This skips version 6.4.3 of pyside6 when testing to avoid the problems described in napari#5657. It does not close that issue, but at least reduces noise on the PR tests. - [x] Bug-fix (non-breaking change which fixes an issue) Related to napari#5657 - [x] all tests pass with my change
Czaki
pushed a commit
that referenced
this pull request
Jun 19, 2023
# Description This skips version 6.4.3 of pyside6 when testing to avoid the problems described in #5657. It does not close that issue, but at least reduces noise on the PR tests. ## Type of change - [x] Bug-fix (non-breaking change which fixes an issue) # References Related to #5657 # How has this been tested? - [x] all tests pass with my change
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
# Description This skips version 6.4.3 of pyside6 when testing to avoid the problems described in #5657. It does not close that issue, but at least reduces noise on the PR tests. ## Type of change - [x] Bug-fix (non-breaking change which fixes an issue) # References Related to #5657 # How has this been tested? - [x] all tests pass with my change
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
# Description This skips version 6.4.3 of pyside6 when testing to avoid the problems described in #5657. It does not close that issue, but at least reduces noise on the PR tests. ## Type of change - [x] Bug-fix (non-breaking change which fixes an issue) # References Related to #5657 # How has this been tested? - [x] all tests pass with my change
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
# Description This skips version 6.4.3 of pyside6 when testing to avoid the problems described in #5657. It does not close that issue, but at least reduces noise on the PR tests. ## Type of change - [x] Bug-fix (non-breaking change which fixes an issue) # References Related to #5657 # How has this been tested? - [x] all tests pass with my change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This skips version 6.4.3 of pyside6 when testing to avoid the problems described in #5657. It does not close that issue, but at least reduces noise on the PR tests.
Type of change
References
Related to #5657
How has this been tested?