Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev example for adding custom overlays. #5719

Merged
merged 1 commit into from Apr 14, 2023

Conversation

brisvag
Copy link
Contributor

@brisvag brisvag commented Apr 13, 2023

Fixes/Closes

Requested by @jni in this comment.

Description

This is an example showcasing all the things necessary for adding a new overlay. It's actually pretty short, if you remove the comments, the monkeypatching and the magicgui wiget :)

custom_overlay.mp4

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #5719 (eb79562) into main (a79537c) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5719      +/-   ##
==========================================
- Coverage   89.85%   89.81%   -0.04%     
==========================================
  Files         608      608              
  Lines       51756    51756              
==========================================
- Hits        46504    46485      -19     
- Misses       5252     5271      +19     

see 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@brisvag brisvag requested a review from jni April 13, 2023 13:18
@brisvag
Copy link
Contributor Author

brisvag commented Apr 13, 2023

@kevinyamauchi @alisterburt you might be interested :)

Copy link
Contributor

@alisterburt alisterburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah - this is awesome, thanks for the ping! API looks great 👍

@brisvag
Copy link
Contributor Author

brisvag commented Apr 14, 2023

I should also add an example for sceneoverlays, as those are a bit more complex, but in another PR.

@jni jni added the ready to merge Last chance for comments! Will be merged in ~24h label Apr 14, 2023
@alisterburt alisterburt merged commit eb2385a into napari:main Apr 14, 2023
34 checks passed
@psobolewskiPhD psobolewskiPhD removed the ready to merge Last chance for comments! Will be merged in ~24h label Apr 30, 2023
@Czaki Czaki mentioned this pull request Jun 7, 2023
@Czaki Czaki added this to the 0.4.18 milestone Jun 16, 2023
Czaki pushed a commit that referenced this pull request Jun 19, 2023
# Fixes/Closes
Requested by @jni [in this
comment](#5712 (comment)).

# Description
This is an example showcasing all the things necessary for adding a new
overlay. It's actually pretty short, if you remove the comments, the
monkeypatching and the magicgui wiget :)


https://user-images.githubusercontent.com/23482191/231759807-7e69c3d9-cfea-4d7c-99e4-3b4855e5575e.mp4
Czaki pushed a commit that referenced this pull request Jun 21, 2023
# Fixes/Closes
Requested by @jni [in this
comment](#5712 (comment)).

# Description
This is an example showcasing all the things necessary for adding a new
overlay. It's actually pretty short, if you remove the comments, the
monkeypatching and the magicgui wiget :)


https://user-images.githubusercontent.com/23482191/231759807-7e69c3d9-cfea-4d7c-99e4-3b4855e5575e.mp4
Czaki pushed a commit that referenced this pull request Jun 21, 2023
# Fixes/Closes
Requested by @jni [in this
comment](#5712 (comment)).

# Description
This is an example showcasing all the things necessary for adding a new
overlay. It's actually pretty short, if you remove the comments, the
monkeypatching and the magicgui wiget :)


https://user-images.githubusercontent.com/23482191/231759807-7e69c3d9-cfea-4d7c-99e4-3b4855e5575e.mp4
Czaki pushed a commit that referenced this pull request Jun 21, 2023
# Fixes/Closes
Requested by @jni [in this
comment](#5712 (comment)).

# Description
This is an example showcasing all the things necessary for adding a new
overlay. It's actually pretty short, if you remove the comments, the
monkeypatching and the magicgui wiget :)


https://user-images.githubusercontent.com/23482191/231759807-7e69c3d9-cfea-4d7c-99e4-3b4855e5575e.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants