Update status bar on active layer change #5754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5754 +/- ##
==========================================
+ Coverage 89.83% 89.85% +0.01%
==========================================
Files 608 608
Lines 51881 51882 +1
==========================================
+ Hits 46608 46618 +10
+ Misses 5273 5264 -9
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Czaki
approved these changes
Apr 21, 2023
alisterburt
approved these changes
Apr 22, 2023
There was a problem hiding this comment.
Welcome @jnahlers ! Awesome first PR, thank you for taking the time to contribute and congratulations 🚀
psobolewskiPhD
removed
the
ready to merge
Czaki
pushed a commit
that referenced
this pull request
Jun 19, 2023
<!-- In general, PRs should fix an existing issue on the repo. --> <!-- Please link to that issue here as "Closes #(issue-number)". --> Closes #5749 <!-- What does this pull request (PR) do? Why is it necessary? --> <!-- Tell us about your new feature, improvement, or fix! --> <!-- If your change includes user interface changes, please add an image, or an animation "An image is worth a thousand words!" --> <!-- You can use https://www.cockos.com/licecap/ or similar to create animations --> Updates the status bar when updating the viewer's state on a new active layer being selected. I just decided to call `ViewerModel`'s `_update_status_bar_from_cursor` at the end of `_on_active_layer`, instead of adding a new connection from `self.layers.selection.events.active` to `_update_status_bar_from_cursor`, as I thought it cleaner to have one connection and put all viewer state update code in `_on_active_layer`. <!-- What resources, documentation, and guides were used in the creation of this PR? --> <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update I have not tested. - [x] My PR is the minimum possible work for the desired functionality - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If I included new strings, I have used `trans.` to make them localizable. For more information see our [translations guide](https://napari.org/developers/translations.html).
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
<!-- In general, PRs should fix an existing issue on the repo. --> <!-- Please link to that issue here as "Closes #(issue-number)". --> Closes #5749 <!-- What does this pull request (PR) do? Why is it necessary? --> <!-- Tell us about your new feature, improvement, or fix! --> <!-- If your change includes user interface changes, please add an image, or an animation "An image is worth a thousand words!" --> <!-- You can use https://www.cockos.com/licecap/ or similar to create animations --> Updates the status bar when updating the viewer's state on a new active layer being selected. I just decided to call `ViewerModel`'s `_update_status_bar_from_cursor` at the end of `_on_active_layer`, instead of adding a new connection from `self.layers.selection.events.active` to `_update_status_bar_from_cursor`, as I thought it cleaner to have one connection and put all viewer state update code in `_on_active_layer`. <!-- What resources, documentation, and guides were used in the creation of this PR? --> <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update I have not tested. - [x] My PR is the minimum possible work for the desired functionality - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If I included new strings, I have used `trans.` to make them localizable. For more information see our [translations guide](https://napari.org/developers/translations.html).
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
<!-- In general, PRs should fix an existing issue on the repo. --> <!-- Please link to that issue here as "Closes #(issue-number)". --> Closes #5749 <!-- What does this pull request (PR) do? Why is it necessary? --> <!-- Tell us about your new feature, improvement, or fix! --> <!-- If your change includes user interface changes, please add an image, or an animation "An image is worth a thousand words!" --> <!-- You can use https://www.cockos.com/licecap/ or similar to create animations --> Updates the status bar when updating the viewer's state on a new active layer being selected. I just decided to call `ViewerModel`'s `_update_status_bar_from_cursor` at the end of `_on_active_layer`, instead of adding a new connection from `self.layers.selection.events.active` to `_update_status_bar_from_cursor`, as I thought it cleaner to have one connection and put all viewer state update code in `_on_active_layer`. <!-- What resources, documentation, and guides were used in the creation of this PR? --> <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update I have not tested. - [x] My PR is the minimum possible work for the desired functionality - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If I included new strings, I have used `trans.` to make them localizable. For more information see our [translations guide](https://napari.org/developers/translations.html).
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
<!-- In general, PRs should fix an existing issue on the repo. --> <!-- Please link to that issue here as "Closes #(issue-number)". --> Closes #5749 <!-- What does this pull request (PR) do? Why is it necessary? --> <!-- Tell us about your new feature, improvement, or fix! --> <!-- If your change includes user interface changes, please add an image, or an animation "An image is worth a thousand words!" --> <!-- You can use https://www.cockos.com/licecap/ or similar to create animations --> Updates the status bar when updating the viewer's state on a new active layer being selected. I just decided to call `ViewerModel`'s `_update_status_bar_from_cursor` at the end of `_on_active_layer`, instead of adding a new connection from `self.layers.selection.events.active` to `_update_status_bar_from_cursor`, as I thought it cleaner to have one connection and put all viewer state update code in `_on_active_layer`. <!-- What resources, documentation, and guides were used in the creation of this PR? --> <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update I have not tested. - [x] My PR is the minimum possible work for the desired functionality - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] If I included new strings, I have used `trans.` to make them localizable. For more information see our [translations guide](https://napari.org/developers/translations.html).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Closes
Closes #5749
Description
Updates the status bar when updating the viewer's state on a new active layer being selected. I just decided to call
ViewerModel's_update_status_bar_from_cursorat the end of_on_active_layer, instead of adding a new connection fromself.layers.selection.events.activeto_update_status_bar_from_cursor, as I thought it cleaner to have one connection and put all viewer state update code in_on_active_layer.References
Type of change
How has this been tested?
I have not tested.
Final checklist:
trans.to make them localizable.For more information see our translations guide.