Bugfix: force a redraw to ensure highlight shows when Points are select-all selected #5771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5771 +/- ##
==========================================
+ Coverage 89.85% 89.87% +0.01%
==========================================
Files 609 610 +1
Lines 52055 52121 +66
==========================================
+ Hits 46775 46842 +67
+ Misses 5280 5279 -1
... and 21 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
alisterburt
approved these changes
Apr 29, 2023
Czaki
pushed a commit
that referenced
this pull request
Jun 19, 2023
…ct-all selected (#5771) # Fixes/Closes Bug discussed here: #5748 (comment) # Description If you are using the + tool or select tool and use the select-all keybind, then the points are not visually selected. If you use the + tool and use select-all then toggle to the selection tool, then they will be visually selected. If you use the select tool, then they never appear to get visually selected. This is because the keybind calls `layer._set_highlight()` but doesn't force a redraw using `force=True`. This PR uses `layer._set_highlight(force=True)` to ensure that a redraw happens, so the visual selection occurs. # References Discussion starts here: #5748 (comment) ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [ ] example: the test suite for my feature covers cases x, y, and z - [x] example: all tests pass with my change - [ ] example: I check if my changes works with both PySide and PyQt backends as there are small differences between the two Qt bindings. ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
…ct-all selected (#5771) # Fixes/Closes Bug discussed here: #5748 (comment) # Description If you are using the + tool or select tool and use the select-all keybind, then the points are not visually selected. If you use the + tool and use select-all then toggle to the selection tool, then they will be visually selected. If you use the select tool, then they never appear to get visually selected. This is because the keybind calls `layer._set_highlight()` but doesn't force a redraw using `force=True`. This PR uses `layer._set_highlight(force=True)` to ensure that a redraw happens, so the visual selection occurs. # References Discussion starts here: #5748 (comment) ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [ ] example: the test suite for my feature covers cases x, y, and z - [x] example: all tests pass with my change - [ ] example: I check if my changes works with both PySide and PyQt backends as there are small differences between the two Qt bindings. ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
…ct-all selected (#5771) # Fixes/Closes Bug discussed here: #5748 (comment) # Description If you are using the + tool or select tool and use the select-all keybind, then the points are not visually selected. If you use the + tool and use select-all then toggle to the selection tool, then they will be visually selected. If you use the select tool, then they never appear to get visually selected. This is because the keybind calls `layer._set_highlight()` but doesn't force a redraw using `force=True`. This PR uses `layer._set_highlight(force=True)` to ensure that a redraw happens, so the visual selection occurs. # References Discussion starts here: #5748 (comment) ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [ ] example: the test suite for my feature covers cases x, y, and z - [x] example: all tests pass with my change - [ ] example: I check if my changes works with both PySide and PyQt backends as there are small differences between the two Qt bindings. ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
…ct-all selected (#5771) # Fixes/Closes Bug discussed here: #5748 (comment) # Description If you are using the + tool or select tool and use the select-all keybind, then the points are not visually selected. If you use the + tool and use select-all then toggle to the selection tool, then they will be visually selected. If you use the select tool, then they never appear to get visually selected. This is because the keybind calls `layer._set_highlight()` but doesn't force a redraw using `force=True`. This PR uses `layer._set_highlight(force=True)` to ensure that a redraw happens, so the visual selection occurs. # References Discussion starts here: #5748 (comment) ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [ ] example: the test suite for my feature covers cases x, y, and z - [x] example: all tests pass with my change - [ ] example: I check if my changes works with both PySide and PyQt backends as there are small differences between the two Qt bindings. ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Closes
Bug discussed here: #5748 (comment)
Description
If you are using the + tool or select tool and use the select-all keybind, then the points are not visually selected.
If you use the + tool and use select-all then toggle to the selection tool, then they will be visually selected.
If you use the select tool, then they never appear to get visually selected.
This is because the keybind calls
layer._set_highlight()but doesn't force a redraw usingforce=True.This PR uses
layer._set_highlight(force=True)to ensure that a redraw happens, so the visual selection occurs.References
Discussion starts here:
#5748 (comment)
Type of change
How has this been tested?
as there are small differences between the two Qt bindings.
Final checklist: