Fix multiple viewer example #5796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5796 +/- ##
==========================================
+ Coverage 89.83% 89.89% +0.06%
==========================================
Files 614 614
Lines 52210 52283 +73
==========================================
+ Hits 46901 47001 +100
+ Misses 5309 5282 -27
|
GenevieveBuckley
approved these changes
May 9, 2023
There was a problem hiding this comment.
Nice fix, thank you!
Request adding viewer.open_sample('napari', 'cells3d') or similar to the end of the Multiple viewer widget example script. Then that can be the test ensuring #5778 does not happen again without us knowing (assuming eventually we will run the example scripts in CI).
|
I don't know why only one CI job failed to complete. I'm re-running it now with debug logging turned on: https://github.com/napari/napari/actions/runs/4924316285/jobs/8814505444 |
|
The "macos-latest 3.9 pyqt5" tests passed on the second run, so I'm guessing the CI was just a bit flaky the first time. Merging now that all the CI checks have passed. Thank you @Czaki 🎉 |
Czaki
added
the
triaged-0.4.18
Czaki
added a commit
that referenced
this pull request
Jun 19, 2023
Closes #5778 After changes in Dims there is a need to fix the multiple_viewer_widget example script. - [x] Bug-fix (non-breaking change which fixes an issue) - [x] all tests pass with my change - [x] the example script multiple_viewer_widget.py was run successfully and the cells3d sample dataset could be opened Co-authored-by: Genevieve Buckley <30920819+GenevieveBuckley@users.noreply.github.com>
Czaki
added a commit
that referenced
this pull request
Jun 21, 2023
Closes #5778 After changes in Dims there is a need to fix the multiple_viewer_widget example script. - [x] Bug-fix (non-breaking change which fixes an issue) - [x] all tests pass with my change - [x] the example script multiple_viewer_widget.py was run successfully and the cells3d sample dataset could be opened Co-authored-by: Genevieve Buckley <30920819+GenevieveBuckley@users.noreply.github.com>
Czaki
added a commit
that referenced
this pull request
Jun 21, 2023
Closes #5778 After changes in Dims there is a need to fix the multiple_viewer_widget example script. - [x] Bug-fix (non-breaking change which fixes an issue) - [x] all tests pass with my change - [x] the example script multiple_viewer_widget.py was run successfully and the cells3d sample dataset could be opened Co-authored-by: Genevieve Buckley <30920819+GenevieveBuckley@users.noreply.github.com>
Czaki
added a commit
that referenced
this pull request
Jun 21, 2023
Closes #5778 After changes in Dims there is a need to fix the multiple_viewer_widget example script. - [x] Bug-fix (non-breaking change which fixes an issue) - [x] all tests pass with my change - [x] the example script multiple_viewer_widget.py was run successfully and the cells3d sample dataset could be opened Co-authored-by: Genevieve Buckley <30920819+GenevieveBuckley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Closes
Closes #5778
Description
After changes in Dims there is a need to fix this example.
References
Type of change
How has this been tested?
as there are small differences between the two Qt bindings.
Final checklist:
trans.to make them localizable.For more information see our translations guide.