Fix colormapping nD images #5805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 4, 2023
Codecov Report
@@ Coverage Diff @@
## main #5805 +/- ##
==========================================
- Coverage 89.96% 89.96% -0.01%
==========================================
Files 615 616 +1
Lines 52639 52633 -6
==========================================
- Hits 47359 47349 -10
- Misses 5280 5284 +4
|
andy-sweet
approved these changes
May 16, 2023
andy-sweet
added
the
ready to merge
andy-sweet
reviewed
May 17, 2023
Czaki
removed
the
ready to merge
Co-authored-by: Andy Sweet <andrew.d.sweet@gmail.com>
andy-sweet
added
the
ready to merge
|
Restarting the 24h clock. I'll likely merge this tomorrow. |
Czaki
approved these changes
May 22, 2023
jni
approved these changes
May 23, 2023
Czaki
removed
the
ready to merge
Czaki
pushed a commit
that referenced
this pull request
Jun 19, 2023
# Description Colormap mapping of arrays with more than 1 dimension is broken due to stacking along the wrong dimension. ## Type of change - [x] Bug-fix (non-breaking change which fixes an issue) --------- Co-authored-by: Andy Sweet <andrew.d.sweet@gmail.com>
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
# Description Colormap mapping of arrays with more than 1 dimension is broken due to stacking along the wrong dimension. ## Type of change - [x] Bug-fix (non-breaking change which fixes an issue) --------- Co-authored-by: Andy Sweet <andrew.d.sweet@gmail.com>
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
# Description Colormap mapping of arrays with more than 1 dimension is broken due to stacking along the wrong dimension. ## Type of change - [x] Bug-fix (non-breaking change which fixes an issue) --------- Co-authored-by: Andy Sweet <andrew.d.sweet@gmail.com>
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
# Description Colormap mapping of arrays with more than 1 dimension is broken due to stacking along the wrong dimension. ## Type of change - [x] Bug-fix (non-breaking change which fixes an issue) --------- Co-authored-by: Andy Sweet <andrew.d.sweet@gmail.com>
brisvag
added a commit
that referenced
this pull request
Jul 23, 2023
# Description When working with custom colormaps, reader and writers trying to use that colormap will fail because the only information returned by `Layer.get_state` is the colormap name. This works fine with builtin colormaps, but anything custom will fail due to `[unnamed colormap 0]` not existing. By returning the full colormap model (in dict form) we can also account for this. Plugin writers and readers using `colormap` will likely break (like our napari-svg) because they assume it to be a string. Note that this includes #5805. which is a lot smaller and just a bug fix. # References <!-- What resources, documentation, and guides were used in the creation of this PR? --> ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update --------- Co-authored-by: Kyle I S Harrington <kephale@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Colormap mapping of arrays with more than 1 dimension is broken due to stacking along the wrong dimension.
Type of change