Update PIP_CONSTRAINT value to fix failing comprehensive jobs
#5809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5809 +/- ##
==========================================
+ Coverage 89.86% 89.89% +0.02%
==========================================
Files 614 614
Lines 52207 52207
==========================================
+ Hits 46915 46929 +14
+ Misses 5292 5278 -14 |
Czaki
approved these changes
May 5, 2023
Czaki
added
the
triaged-0.4.18
Czaki
pushed a commit
that referenced
this pull request
Jun 19, 2023
# Fixes/Closes <!-- In general, PRs should fix an existing issue on the repo. --> <!-- Please link to that issue here as "Closes #(issue-number)". --> Closes #5699 # Description <!-- What does this pull request (PR) do? Why is it necessary? --> <!-- Tell us about your new feature, improvement, or fix! --> <!-- If your change includes user interface changes, please add an image, or an animation "An image is worth a thousand words!" --> <!-- You can use https://www.cockos.com/licecap/ or similar to create animations --> Seems like the [ubuntu-20.04 py3.8 min_req](https://github.com/napari/napari/actions/runs/4887837766/jobs/8724894744#logs) and [test examples](https://github.com/napari/napari/actions/runs/4887837766/jobs/8724895070#logs) jobs are failing due to `PIP_CONSTRAINT` missing to be set to the correct values (`constraints_py3.8_min_req.txt` and `constraints_py3.9_examples.txt`) # References <!-- What resources, documentation, and guides were used in the creation of this PR? --> ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [x] all tests pass with my change ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
# Fixes/Closes <!-- In general, PRs should fix an existing issue on the repo. --> <!-- Please link to that issue here as "Closes #(issue-number)". --> Closes #5699 # Description <!-- What does this pull request (PR) do? Why is it necessary? --> <!-- Tell us about your new feature, improvement, or fix! --> <!-- If your change includes user interface changes, please add an image, or an animation "An image is worth a thousand words!" --> <!-- You can use https://www.cockos.com/licecap/ or similar to create animations --> Seems like the [ubuntu-20.04 py3.8 min_req](https://github.com/napari/napari/actions/runs/4887837766/jobs/8724894744#logs) and [test examples](https://github.com/napari/napari/actions/runs/4887837766/jobs/8724895070#logs) jobs are failing due to `PIP_CONSTRAINT` missing to be set to the correct values (`constraints_py3.8_min_req.txt` and `constraints_py3.9_examples.txt`) # References <!-- What resources, documentation, and guides were used in the creation of this PR? --> ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [x] all tests pass with my change ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
# Fixes/Closes <!-- In general, PRs should fix an existing issue on the repo. --> <!-- Please link to that issue here as "Closes #(issue-number)". --> Closes #5699 # Description <!-- What does this pull request (PR) do? Why is it necessary? --> <!-- Tell us about your new feature, improvement, or fix! --> <!-- If your change includes user interface changes, please add an image, or an animation "An image is worth a thousand words!" --> <!-- You can use https://www.cockos.com/licecap/ or similar to create animations --> Seems like the [ubuntu-20.04 py3.8 min_req](https://github.com/napari/napari/actions/runs/4887837766/jobs/8724894744#logs) and [test examples](https://github.com/napari/napari/actions/runs/4887837766/jobs/8724895070#logs) jobs are failing due to `PIP_CONSTRAINT` missing to be set to the correct values (`constraints_py3.8_min_req.txt` and `constraints_py3.9_examples.txt`) # References <!-- What resources, documentation, and guides were used in the creation of this PR? --> ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [x] all tests pass with my change ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
# Fixes/Closes <!-- In general, PRs should fix an existing issue on the repo. --> <!-- Please link to that issue here as "Closes #(issue-number)". --> Closes #5699 # Description <!-- What does this pull request (PR) do? Why is it necessary? --> <!-- Tell us about your new feature, improvement, or fix! --> <!-- If your change includes user interface changes, please add an image, or an animation "An image is worth a thousand words!" --> <!-- You can use https://www.cockos.com/licecap/ or similar to create animations --> Seems like the [ubuntu-20.04 py3.8 min_req](https://github.com/napari/napari/actions/runs/4887837766/jobs/8724894744#logs) and [test examples](https://github.com/napari/napari/actions/runs/4887837766/jobs/8724895070#logs) jobs are failing due to `PIP_CONSTRAINT` missing to be set to the correct values (`constraints_py3.8_min_req.txt` and `constraints_py3.9_examples.txt`) # References <!-- What resources, documentation, and guides were used in the creation of this PR? --> ## Type of change <!-- Please delete options that are not relevant. --> - [x] Bug-fix (non-breaking change which fixes an issue) # How has this been tested? <!-- Please describe the tests that you ran to verify your changes. --> - [x] all tests pass with my change ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Closes
Closes #5699
Description
Seems like the ubuntu-20.04 py3.8 min_req and test examples jobs are failing due to
PIP_CONSTRAINTmissing to be set to the correct values (constraints_py3.8_min_req.txtandconstraints_py3.9_examples.txt)References
Type of change
How has this been tested?
Final checklist: