Set focus policy for mainwindow to prevent keeping focus on the axis labels (and other QLineEdit based widgets) when clicking outside the widget
#5812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…labels (and other QLineEdit based widgets) when clicking outside the line edit widget area
dalthviz
changed the title
QLineEdit based widgets) when clicking outside the widget
Codecov Report
@@ Coverage Diff @@
## main #5812 +/- ##
==========================================
+ Coverage 89.83% 89.88% +0.05%
==========================================
Files 614 614
Lines 52210 52211 +1
==========================================
+ Hits 46901 46929 +28
+ Misses 5309 5282 -27
|
kephale
approved these changes
Jun 22, 2023
jni
approved these changes
Jun 22, 2023
Czaki
pushed a commit
that referenced
this pull request
Jun 23, 2023
…labels (and other `QLineEdit` based widgets) when clicking outside the widget (#5812) # Fixes/Closes Closes #1571 # Description This changes the focus policy for the `_QtMainWindow` class to be set to `Qt.FocusPolicy.StrongFocus`. With this change, the axis label line edit widget is able to loss focus when clicking outside it (as well as other `QLineEdit` based widgets): 
melissawm
pushed a commit
to melissawm/napari
that referenced
this pull request
Jul 3, 2023
…labels (and other `QLineEdit` based widgets) when clicking outside the widget (napari#5812) # Fixes/Closes Closes napari#1571 # Description This changes the focus policy for the `_QtMainWindow` class to be set to `Qt.FocusPolicy.StrongFocus`. With this change, the axis label line edit widget is able to loss focus when clicking outside it (as well as other `QLineEdit` based widgets): 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Closes
Closes #1571
Description
This changes the focus policy for the
_QtMainWindowclass to be set toQt.FocusPolicy.StrongFocus. With this change, the axis label line edit widget is able to loss focus when clicking outside it (as well as otherQLineEditbased widgets):Type of change
How has this been tested?
as there are small differences between the two Qt bindings.
Final checklist: