-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Disconnect callbacks on object deletion in special functions from event_utils
#5826
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5826 +/- ##
==========================================
+ Coverage 89.90% 89.93% +0.02%
==========================================
Files 615 616 +1
Lines 52322 52372 +50
==========================================
+ Hits 47041 47101 +60
+ Misses 5281 5271 -10
|
event_utils
event_utils
@Czaki I cleaned up the title and OP plus the comment. |
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
event_utils
event_utils
I have updated the title as methods is the name for functions bound to the class. I have hope that I do not break the title. Could you check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a stray comment, pretty sure it was unintentional but I've left the removal as a suggestion. Otherwise, 👍
@jni read comment in the first function. I may copy it to all. The general problem is that the proper way to do this is to use finalize, but it causes segfaults. I have a hope that Qt6 may work for this better, so I prefer not to remove it but left commented until drop qt5/ |
Fixes/Closes
Closes #5808
Description
Adds cleaning callback steps on object deletion and adds proper tests.
References
Type of change
How has this been tested?
Final checklist: