Do not blend color in QtColorBox with black using opacity #5827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a need to update tests also |
Fixed |
Codecov Report
@@ Coverage Diff @@
## main #5827 +/- ##
==========================================
+ Coverage 89.86% 89.91% +0.04%
==========================================
Files 615 615
Lines 52474 52473 -1
==========================================
+ Hits 47158 47182 +24
+ Misses 5316 5291 -25
|
Czaki
approved these changes
May 12, 2023
brisvag
changed the title
brisvag
removed
the
ready to merge
Czaki
pushed a commit
that referenced
this pull request
Jun 19, 2023
…ion; bugfix? ) (#5827) # Description For some reason that I cannot fully understand, the displayed color in QtColorBox is multiplied with the layer opacity, which is equal to blending the selected color with black. I find it very misleading as it just distorts displayed colors making them harder to associate with the true colors. It becomes especially confusing when you use low levels of opacity (20-30%), which makes all colors look grey and indistinguishable. How it now looks like in napari depending on different opacity:  This PR just removes it making it always show the actual color. P.S. It has been puzzling me for a while why colors are always darker than the real colors in the color box. I've only recently realized that their appearance is depending on the opacity. ## Type of change - [X] Bug-fix (non-breaking change which fixes an issue) ## Final checklist: - [X] My PR is the minimum possible work for the desired functionality
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
…ion; bugfix? ) (#5827) # Description For some reason that I cannot fully understand, the displayed color in QtColorBox is multiplied with the layer opacity, which is equal to blending the selected color with black. I find it very misleading as it just distorts displayed colors making them harder to associate with the true colors. It becomes especially confusing when you use low levels of opacity (20-30%), which makes all colors look grey and indistinguishable. How it now looks like in napari depending on different opacity:  This PR just removes it making it always show the actual color. P.S. It has been puzzling me for a while why colors are always darker than the real colors in the color box. I've only recently realized that their appearance is depending on the opacity. ## Type of change - [X] Bug-fix (non-breaking change which fixes an issue) ## Final checklist: - [X] My PR is the minimum possible work for the desired functionality
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
…ion; bugfix? ) (#5827) # Description For some reason that I cannot fully understand, the displayed color in QtColorBox is multiplied with the layer opacity, which is equal to blending the selected color with black. I find it very misleading as it just distorts displayed colors making them harder to associate with the true colors. It becomes especially confusing when you use low levels of opacity (20-30%), which makes all colors look grey and indistinguishable. How it now looks like in napari depending on different opacity:  This PR just removes it making it always show the actual color. P.S. It has been puzzling me for a while why colors are always darker than the real colors in the color box. I've only recently realized that their appearance is depending on the opacity. ## Type of change - [X] Bug-fix (non-breaking change which fixes an issue) ## Final checklist: - [X] My PR is the minimum possible work for the desired functionality
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
…ion; bugfix? ) (#5827) # Description For some reason that I cannot fully understand, the displayed color in QtColorBox is multiplied with the layer opacity, which is equal to blending the selected color with black. I find it very misleading as it just distorts displayed colors making them harder to associate with the true colors. It becomes especially confusing when you use low levels of opacity (20-30%), which makes all colors look grey and indistinguishable. How it now looks like in napari depending on different opacity:  This PR just removes it making it always show the actual color. P.S. It has been puzzling me for a while why colors are always darker than the real colors in the color box. I've only recently realized that their appearance is depending on the opacity. ## Type of change - [X] Bug-fix (non-breaking change which fixes an issue) ## Final checklist: - [X] My PR is the minimum possible work for the desired functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some reason that I cannot fully understand, the displayed color in QtColorBox is multiplied with the layer opacity, which is equal to blending the selected color with black. I find it very misleading as it just distorts displayed colors making them harder to associate with the true colors. It becomes especially confusing when you use low levels of opacity (20-30%), which makes all colors look grey and indistinguishable.
How it now looks like in napari depending on different opacity:
This PR just removes it making it always show the actual color.
P.S. It has been puzzling me for a while why colors are always darker than the real colors in the color box. I've only recently realized that their appearance is depending on the opacity.
Type of change
Final checklist: