-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: fix broken "show selected" in the Labels layer (because of caching) #5841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5841 +/- ##
==========================================
- Coverage 89.96% 89.94% -0.03%
==========================================
Files 615 615
Lines 52638 52654 +16
==========================================
+ Hits 47358 47359 +1
- Misses 5280 5295 +15
|
brisvag
approved these changes
May 17, 2023
Nice, thanks for adding the test as well 💪 |
4 tasks
jni
approved these changes
May 24, 2023
Thanks @ksofiyuk 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The labels caching from #5732 broke the "show selected" feature because of caching. This PR fixes it by invalidating the cache when "show selected" is activated.
I also added a test that catches this bug.
Type of change
How has this been tested?
Final checklist: