[Qt6] Fix AttributeError on renaming layer #5850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aganders3
changed the title
Codecov Report
@@ Coverage Diff @@
## main #5850 +/- ##
==========================================
+ Coverage 89.96% 89.98% +0.01%
==========================================
Files 615 615
Lines 52638 52647 +9
==========================================
+ Hits 47358 47376 +18
+ Misses 5280 5271 -9
|
psobolewskiPhD
approved these changes
May 19, 2023
There was a problem hiding this comment.
This works for me in both pyqt6 and pyqt5.
The fix looks correct to me, which can be confirmed reading:
https://doc.qt.io/qtforpython-6/considerations.html#forgiveness-mode-and-type-hints
Czaki
pushed a commit
that referenced
this pull request
Jun 19, 2023
# Fixes/Closes Closes #5849 # Description This is a pretty simple fix, but is also backward-compatible in my testing with Qt5. I added a test to cover this method for the future. I can look into adding more tests for that file as well. ## Type of change - [x] Bug-fix (non-breaking change which fixes an issue) # How has this been tested? Added a test for this feature that fails without a062d79. This test passes with a062d79 on both Qt5 and Qt6. ## Notes @psobolewskiPhD: > This works for me in both pyqt6 and pyqt5. > The fix looks correct to me, which can be confirmed reading: > doc.qt.io/qtforpython-6/considerations.html#forgiveness-mode-and-type-hints
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
# Fixes/Closes Closes #5849 # Description This is a pretty simple fix, but is also backward-compatible in my testing with Qt5. I added a test to cover this method for the future. I can look into adding more tests for that file as well. ## Type of change - [x] Bug-fix (non-breaking change which fixes an issue) # How has this been tested? Added a test for this feature that fails without a062d79. This test passes with a062d79 on both Qt5 and Qt6. ## Notes @psobolewskiPhD: > This works for me in both pyqt6 and pyqt5. > The fix looks correct to me, which can be confirmed reading: > doc.qt.io/qtforpython-6/considerations.html#forgiveness-mode-and-type-hints
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
# Fixes/Closes Closes #5849 # Description This is a pretty simple fix, but is also backward-compatible in my testing with Qt5. I added a test to cover this method for the future. I can look into adding more tests for that file as well. ## Type of change - [x] Bug-fix (non-breaking change which fixes an issue) # How has this been tested? Added a test for this feature that fails without a062d79. This test passes with a062d79 on both Qt5 and Qt6. ## Notes @psobolewskiPhD: > This works for me in both pyqt6 and pyqt5. > The fix looks correct to me, which can be confirmed reading: > doc.qt.io/qtforpython-6/considerations.html#forgiveness-mode-and-type-hints
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
# Fixes/Closes Closes #5849 # Description This is a pretty simple fix, but is also backward-compatible in my testing with Qt5. I added a test to cover this method for the future. I can look into adding more tests for that file as well. ## Type of change - [x] Bug-fix (non-breaking change which fixes an issue) # How has this been tested? Added a test for this feature that fails without a062d79. This test passes with a062d79 on both Qt5 and Qt6. ## Notes @psobolewskiPhD: > This works for me in both pyqt6 and pyqt5. > The fix looks correct to me, which can be confirmed reading: > doc.qt.io/qtforpython-6/considerations.html#forgiveness-mode-and-type-hints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Closes
Closes #5849
Description
This is a pretty simple fix, but is also backward-compatible in my testing with Qt5. I added a test to cover this method for the future. I can look into adding more tests for that file as well.
Type of change
How has this been tested?
Added a test for this feature that fails without a062d79.
This test passes with a062d79 on both Qt5 and Qt6.
Final checklist:
trans.to make them localizable.For more information see our translations guide.