New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add constraints file during installation of packages from pip in docs workflow #5862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Czaki approved but just a small question about the setup.cfg changes. Maybe that should be a different PR?
@@ -76,7 +76,7 @@ install_requires = | |||
tifffile>=2020.2.16 | |||
toolz>=0.10.0 | |||
tqdm>=4.56.0 | |||
typing_extensions | |||
typing_extensions>=4.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this change required in addition to the constraints?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because without this in min req test the latest typing extension is insstaled. And old pydantic is incompatible with the latest typing extension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could split it to separate PR, but I want to reduce the time to merge bugfix as fast as possible.
@Czaki docs are building here in this PR, but not in napari/docs -- do we need to port this to that repo too? |
I think yes. |
I merged main and looks like the docs issue is fixed for PRs in this repo: |
# Description This will prevent releases of upstream packages from breaking our docs builds. Copied changes from napari/napari#5862
… workflow (#5862) Add usage of constraints in build docs process to reduce failed workflows caused by updates of dependency. I also add a lower pin to typing-extension to keep min-req test working.
… workflow (#5862) Add usage of constraints in build docs process to reduce failed workflows caused by updates of dependency. I also add a lower pin to typing-extension to keep min-req test working.
… workflow (#5862) Add usage of constraints in build docs process to reduce failed workflows caused by updates of dependency. I also add a lower pin to typing-extension to keep min-req test working.
… workflow (#5862) Add usage of constraints in build docs process to reduce failed workflows caused by updates of dependency. I also add a lower pin to typing-extension to keep min-req test working.
Description
Add usage of constraints in build docs process to reduce failed workflows caused by updates of dependency.
I also add a lower pin to typing-extension to keep min-req test working.
References
Type of change
How has this been tested?
as there are small differences between the two Qt bindings.
Final checklist:
trans.
to make them localizable.For more information see our translations guide.