Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constraints file during installation of packages from pip in docs workflow #5862

Merged
merged 2 commits into from May 25, 2023

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented May 23, 2023

Description

Add usage of constraints in build docs process to reduce failed workflows caused by updates of dependency.

I also add a lower pin to typing-extension to keep min-req test working.

References

Type of change

  • Bug-fix (non-breaking change which fixes an issue)

How has this been tested?

  • example: the test suite for my feature covers cases x, y, and z
  • example: all tests pass with my change
  • example: I check if my changes works with both PySide and PyQt backends
    as there are small differences between the two Qt bindings.

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • If I included new strings, I have used trans. to make them localizable.
    For more information see our translations guide.

@Czaki Czaki added the bugfix PR with bugfix label May 23, 2023
@github-actions github-actions bot added the task label May 23, 2023
@Czaki Czaki changed the title I add usage of constraints file during installation of packages from pip in docs workflow Add constraints file during installation of packages from pip in docs workflow May 23, 2023
Copy link
Member

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Czaki approved but just a small question about the setup.cfg changes. Maybe that should be a different PR?

@@ -76,7 +76,7 @@ install_requires =
tifffile>=2020.2.16
toolz>=0.10.0
tqdm>=4.56.0
typing_extensions
typing_extensions>=4.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this change required in addition to the constraints?

Copy link
Collaborator Author

@Czaki Czaki May 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because without this in min req test the latest typing extension is insstaled. And old pydantic is incompatible with the latest typing extension

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could split it to separate PR, but I want to reduce the time to merge bugfix as fast as possible.

@Czaki Czaki added the ready to merge Last chance for comments! Will be merged in ~24h label May 24, 2023
@psobolewskiPhD
Copy link
Member

@Czaki docs are building here in this PR, but not in napari/docs -- do we need to port this to that repo too?

@Czaki
Copy link
Collaborator Author

Czaki commented May 24, 2023

I think yes.

@jni jni merged commit 7110a32 into napari:main May 25, 2023
31 checks passed
@jni jni deleted the use_constrains branch May 25, 2023 05:55
@jni jni removed the ready to merge Last chance for comments! Will be merged in ~24h label May 25, 2023
@jni jni added this to the 0.5.0 milestone May 25, 2023
@psobolewskiPhD
Copy link
Member

I merged main and looks like the docs issue is fixed for PRs in this repo:
https://github.com/napari/napari/actions/runs/5076767489/jobs/9119271941?pr=5618
But build docs action in PRs in docs repo still fail:
https://github.com/napari/docs/actions/runs/5059087523/jobs/9119586997
so looks like we need to port over this fix (and I guess it means some dependency update is crashing our examples?)

jni pushed a commit to napari/docs that referenced this pull request May 25, 2023
# Description

This will prevent releases of upstream packages from breaking our docs builds.

Copied changes from napari/napari#5862
@Czaki Czaki mentioned this pull request Jun 7, 2023
@Czaki Czaki modified the milestones: 0.5.0, 0.4.18 Jun 16, 2023
Czaki added a commit that referenced this pull request Jun 19, 2023
… workflow (#5862)

Add usage of constraints in build docs process to reduce failed
workflows caused by updates of dependency.

I also add a lower pin to typing-extension to keep min-req test working.
Czaki added a commit that referenced this pull request Jun 21, 2023
… workflow (#5862)

Add usage of constraints in build docs process to reduce failed
workflows caused by updates of dependency.

I also add a lower pin to typing-extension to keep min-req test working.
Czaki added a commit that referenced this pull request Jun 21, 2023
… workflow (#5862)

Add usage of constraints in build docs process to reduce failed
workflows caused by updates of dependency.

I also add a lower pin to typing-extension to keep min-req test working.
Czaki added a commit that referenced this pull request Jun 21, 2023
… workflow (#5862)

Add usage of constraints in build docs process to reduce failed
workflows caused by updates of dependency.

I also add a lower pin to typing-extension to keep min-req test working.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR with bugfix task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants