Fix drawing vertical or horizontal line segments in Shapes layer #5895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psobolewskiPhD
approved these changes
Jun 5, 2023
jni
changed the title
Czaki
pushed a commit
that referenced
this pull request
Jun 19, 2023
Closes #4538. In #4538, @psobolewskiPhD reported that *something* prevented drawing of Shapes line segments that were either perfectly vertical or perfectly horizontal. This was caused by faulty logic meant to prevent drawing segments that are *too small*. This changes the logic to prevent changing a scale to 0, which fixes the bug. It also renames some variables to make the logic easier to follow.
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
Closes #4538. In #4538, @psobolewskiPhD reported that *something* prevented drawing of Shapes line segments that were either perfectly vertical or perfectly horizontal. This was caused by faulty logic meant to prevent drawing segments that are *too small*. This changes the logic to prevent changing a scale to 0, which fixes the bug. It also renames some variables to make the logic easier to follow.
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
Closes #4538. In #4538, @psobolewskiPhD reported that *something* prevented drawing of Shapes line segments that were either perfectly vertical or perfectly horizontal. This was caused by faulty logic meant to prevent drawing segments that are *too small*. This changes the logic to prevent changing a scale to 0, which fixes the bug. It also renames some variables to make the logic easier to follow.
Czaki
pushed a commit
that referenced
this pull request
Jun 21, 2023
Closes #4538. In #4538, @psobolewskiPhD reported that *something* prevented drawing of Shapes line segments that were either perfectly vertical or perfectly horizontal. This was caused by faulty logic meant to prevent drawing segments that are *too small*. This changes the logic to prevent changing a scale to 0, which fixes the bug. It also renames some variables to make the logic easier to follow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4538.
In #4538, @psobolewskiPhD reported that something prevented drawing of Shapes line segments that were either perfectly vertical or perfectly horizontal. This was caused by faulty logic meant to prevent drawing segments that are too small. This changes the logic to prevent changing a scale to 0, which fixes the bug. It also renames some variables to make the logic easier to follow.