-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update upgrade dependecies and test workflows #5919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't really fixing a bug in napari, so maybe better to label as Maintenance?
Codecov Report
@@ Coverage Diff @@
## main #5919 +/- ##
==========================================
+ Coverage 90.20% 90.21% +0.01%
==========================================
Files 619 619
Lines 52954 52954
==========================================
+ Hits 47766 47775 +9
+ Misses 5188 5179 -9 |
- python: 3.11 | ||
platform: ubuntu-latest | ||
backend: pyside6 | ||
exclude: | ||
- python: "3.11" | ||
backend: pyside2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Czaki why is it 3.11
in some sections and "3.11"
in others? If possible, it would be good to be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be "3.11"
everywhere for consistency with 3.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you like me to push that change to the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I'm a-pushing! 😅
Fixes/Closes
Closes #5884
Description
mypy
requirements.References
Type of change
How has this been tested?
as there are small differences between the two Qt bindings.
Final checklist:
trans.
to make them localizable.For more information see our translations guide.