Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upgrade dependecies and test workflows #5919

Merged
merged 5 commits into from
Jun 12, 2023
Merged

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Jun 9, 2023

Fixes/Closes

Closes #5884

Description

References

Type of change

  • Bug-fix (non-breaking change which fixes an issue)

How has this been tested?

  • example: the test suite for my feature covers cases x, y, and z
  • example: all tests pass with my change
  • example: I check if my changes works with both PySide and PyQt backends
    as there are small differences between the two Qt bindings.

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • If I included new strings, I have used trans. to make them localizable.
    For more information see our translations guide.

@github-actions github-actions bot added the task label Jun 9, 2023
@Czaki Czaki added the bugfix PR with bugfix label Jun 9, 2023
Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really fixing a bug in napari, so maybe better to label as Maintenance?

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #5919 (2d9b363) into main (f2d7d43) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5919      +/-   ##
==========================================
+ Coverage   90.20%   90.21%   +0.01%     
==========================================
  Files         619      619              
  Lines       52954    52954              
==========================================
+ Hits        47766    47775       +9     
+ Misses       5188     5179       -9     

see 4 files with indirect coverage changes

Comment on lines 68 to 73
- python: 3.11
platform: ubuntu-latest
backend: pyside6
exclude:
- python: "3.11"
backend: pyside2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Czaki why is it 3.11 in some sections and "3.11" in others? If possible, it would be good to be consistent.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be "3.11" everywhere for consistency with 3.10

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you like me to push that change to the PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'm a-pushing! 😅

@jni jni merged commit 0ef89b2 into napari:main Jun 12, 2023
31 checks passed
@jni jni deleted the fix_constraints branch June 12, 2023 01:38
@Czaki Czaki removed the ready to merge Last chance for comments! Will be merged in ~24h label Jun 12, 2023
@Czaki Czaki added this to the 0.4.18 milestone Jun 12, 2023
Czaki added a commit that referenced this pull request Jun 19, 2023
Closes #5884

* Disable PySide2 test on python 3.11
* Enable Pyside6 and PyQt6 in comprehensive matrix 
* fix constrains files names from #5439
* add upgrading `mypy` requirements. 

---------

Co-authored-by: Juan Nunez-Iglesias <jni@fastmail.com>
Czaki added a commit that referenced this pull request Jun 21, 2023
Closes #5884

* Disable PySide2 test on python 3.11
* Enable Pyside6 and PyQt6 in comprehensive matrix 
* fix constrains files names from #5439
* add upgrading `mypy` requirements. 

---------

Co-authored-by: Juan Nunez-Iglesias <jni@fastmail.com>
Czaki added a commit that referenced this pull request Jun 21, 2023
Closes #5884

* Disable PySide2 test on python 3.11
* Enable Pyside6 and PyQt6 in comprehensive matrix 
* fix constrains files names from #5439
* add upgrading `mypy` requirements. 

---------

Co-authored-by: Juan Nunez-Iglesias <jni@fastmail.com>
Czaki added a commit that referenced this pull request Jun 21, 2023
Closes #5884

* Disable PySide2 test on python 3.11
* Enable Pyside6 and PyQt6 in comprehensive matrix 
* fix constrains files names from #5439
* add upgrading `mypy` requirements. 

---------

Co-authored-by: Juan Nunez-Iglesias <jni@fastmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PR with maintance changes, task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[test-bot] Comprehensive tests failing
4 participants