Fix napari-svg version parsing in conftest.py
#5947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Czaki
force-pushed
the
fix_napari_svg_version
branch
from
fa21408
to
4035553
Compare
Czaki
force-pushed
the
fix_napari_svg_version
branch
from
8a70fcc
to
f9614d5
Compare
Codecov Report
@@ Coverage Diff @@
## main #5947 +/- ##
=======================================
Coverage 90.19% 90.20%
=======================================
Files 615 615
Lines 52038 52039 +1
=======================================
+ Hits 46938 46941 +3
+ Misses 5100 5098 -2
|
Czaki
changed the title
napari-svg version parsing in conftest.py
Czaki
added a commit
that referenced
this pull request
Jun 17, 2023
# Description
Fixes problem with parsing `napari-svg` version as `("0", "1", "10") <
("0", "1", "6")` because of using lexicographical compression.
## Type of change
<!-- Please delete options that are not relevant. -->
- [x] Bug-fix (non-breaking change which fixes an issue)
Czaki
added a commit
that referenced
this pull request
Jun 18, 2023
# Description
Fixes problem with parsing `napari-svg` version as `("0", "1", "10") <
("0", "1", "6")` because of using lexicographical compression.
## Type of change
<!-- Please delete options that are not relevant. -->
- [x] Bug-fix (non-breaking change which fixes an issue)
Czaki
added a commit
that referenced
this pull request
Jun 19, 2023
# Description
Fixes problem with parsing `napari-svg` version as `("0", "1", "10") <
("0", "1", "6")` because of using lexicographical compression.
## Type of change
<!-- Please delete options that are not relevant. -->
- [x] Bug-fix (non-breaking change which fixes an issue)
Czaki
added a commit
that referenced
this pull request
Jun 21, 2023
# Description
Fixes problem with parsing `napari-svg` version as `("0", "1", "10") <
("0", "1", "6")` because of using lexicographical compression.
## Type of change
<!-- Please delete options that are not relevant. -->
- [x] Bug-fix (non-breaking change which fixes an issue)
Czaki
added a commit
that referenced
this pull request
Jun 21, 2023
# Description
Fixes problem with parsing `napari-svg` version as `("0", "1", "10") <
("0", "1", "6")` because of using lexicographical compression.
## Type of change
<!-- Please delete options that are not relevant. -->
- [x] Bug-fix (non-breaking change which fixes an issue)
Czaki
added a commit
that referenced
this pull request
Jun 21, 2023
# Description
Fixes problem with parsing `napari-svg` version as `("0", "1", "10") <
("0", "1", "6")` because of using lexicographical compression.
## Type of change
<!-- Please delete options that are not relevant. -->
- [x] Bug-fix (non-breaking change which fixes an issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes problem with parsing
napari-svgversion as("0", "1", "10") < ("0", "1", "6")because of using lexicographical compression.References
Type of change