Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tuple for pip constraints to avoid LRU cache error #6036

Merged
merged 3 commits into from Jul 4, 2023

Conversation

jni
Copy link
Member

@jni jni commented Jul 4, 2023

The _pip_constraints function was returning a list of strings, but the function that required it was decorated with lru_cache, causing an error because list is not hashable. See https://forum.image.sc/t/request-for-testing-napari-0-4-18-release-candidate/82833/21.

Type of change

  • Bug-fix (non-breaking change which fixes an issue)

@jni jni added the bugfix PR with bugfix label Jul 4, 2023
@github-actions github-actions bot added qt Relates to qt and removed bugfix PR with bugfix labels Jul 4, 2023
@jni jni added this to the 0.4.18 milestone Jul 4, 2023
@jni
Copy link
Member Author

jni commented Jul 4, 2023

@jaimergp once again — I'm so grateful for the work you've done pulling out this installer 😭 🙏

@jni jni added the bugfix PR with bugfix label Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #6036 (c611d7a) into v0.4.18x (c858b57) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head c611d7a differs from pull request most recent head cf983c1. Consider uploading reports for the commit cf983c1 to get more accurate results

@@             Coverage Diff              @@
##           v0.4.18x    #6036      +/-   ##
============================================
- Coverage     88.71%   88.68%   -0.04%     
============================================
  Files           624      624              
  Lines         52781    52779       -2     
============================================
- Hits          46825    46805      -20     
- Misses         5956     5974      +18     
Impacted Files Coverage Δ
napari/_qt/dialogs/qt_plugin_dialog.py 61.91% <0.00%> (+0.03%) ⬆️

... and 9 files with indirect coverage changes

@jni jni merged commit 20cf5b2 into napari:v0.4.18x Jul 4, 2023
25 of 26 checks passed
@jni jni deleted the lru-wants-tuple branch July 4, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR with bugfix documentation qt Relates to qt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants