Task: remove html comments from pr description #6086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carreau
force-pushed
the
strip-html-comments
branch
2 times, most recently
from
887a4dd
to
7a1289e
Compare
Codecov Report
@@ Coverage Diff @@
## main #6086 +/- ##
==========================================
+ Coverage 91.53% 91.62% +0.08%
==========================================
Files 578 579 +1
Lines 50540 50636 +96
==========================================
+ Hits 46264 46394 +130
+ Misses 4276 4242 -34
|
Carreau
force-pushed
the
strip-html-comments
branch
from
7a1289e
to
52a442b
Compare
Some changes in main are making mypy fix on all new Pull Request. Update typing for CI to pass.
Carreau
force-pushed
the
strip-html-comments
branch
from
52a442b
to
68721c5
Compare
|
What if a comment is explicitly added for example in a code block, like this? <!-- I'm explaining what a comment is -->Pretty unlikely I guess, but this would be removed and leave an empty codeblock... |
|
Yeah, I guess it would be removed, but I think the PR creator, or maintainer would realize. We can also just have a failing status if html comment is present, but that would be yet one more failing status, and I'm tempted to think that if we have issues, we can refine the code when we get there. |
Carreau
commented
Jul 26, 2023
Carreau
force-pushed
the
strip-html-comments
branch
from
68721c5
to
8c61fc5
Compare
|
It should now remove leading/training whitespace, and a single trailing new line if there is one. |
jni
approved these changes
Aug 9, 2023
Czaki
removed
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will edit a PR description to remove any html comment that are present, including leading/trailing whitespace and a single trailing newline if there is one.
As the PRs descriptions are often becoming Merge/rebase-squash messages, this should lead to cleaner commit messages.
Should close #6085