Use class name for object that does not have qt name #6222
Merged
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #6222 +/- ##
==========================================
- Coverage 91.67% 91.67% -0.01%
==========================================
Files 583 583
Lines 51203 51208 +5
==========================================
+ Hits 46942 46943 +1
- Misses 4261 4265 +4
|
brisvag
approved these changes
Sep 12, 2023
|
cc: @melonora |
Carreau
approved these changes
Sep 14, 2023
|
Works for me! Thanks this will make event tracing easier. |
melonora
approved these changes
Sep 15, 2023
melonora
added
the
ready to merge
kne42
added a commit
to kne42/napari
that referenced
this pull request
Sep 19, 2023
* main: (26 commits) Fix some typing in napari.components (napari#6203) Use class name for object that does not have qt name (napari#6222) test: [Automatic] Constraints upgrades: `hypothesis`, `magicgui`, `psygnal`, `tensorstore`, `tifffile`, `tqdm`, `virtualenv` (napari#6143) Replace more np.all( ... = ...) with np.array_equal (napari#6213) remove np.all(... == ...) in test_surface.py (napari#6218) Ensure pandas Series is initialized with a list as data (napari#6226) Stop using temporary directory for store array for paint test (napari#6191) Bugfix: ensure thumbnail represents canvas when multiscale (napari#6200) cleanup np.all(... == ...) from test_points.py (napari#6217) [pre-commit.ci] pre-commit autoupdate (napari#6221) use app-model for file menu (napari#4865) Add tests to cover slicing behavior when changing layers and data (napari#4819) [pre-commit.ci] pre-commit autoupdate (napari#6128) Add test coverage for async slicing of labels (napari#5325) Add collision check when set colors for labels layer (napari#6193) Update "toggle ndview" text (napari#6192) Prevent layer controls buttons changing layout while taking screenshots with flash effect on (napari#6194) Fix typing in napari.utils.perf (napari#6132) Add GUI test coverage for changes to Labels.show_selected_label (napari#5372) Fix types in 'napari.utils.colormaps.categorical_colormap' (napari#6154) ...
Czaki
removed
the
ready to merge
Czaki
added a commit
that referenced
this pull request
Oct 17, 2023
# Description I have found that when the object does not have a set name, our performance tracing only provides the event name without information from which class it comes. So it. is hard to locate the real problem. This PR add using a class name if the object does not have a name.
Merged
Carreau
pushed a commit
that referenced
this pull request
Nov 8, 2023
In #6222 performance monitor was inadvertently broken. This should fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have found that when the object does not have a set name, our performance tracing only provides the event name without information from which class it comes. So it. is hard to locate the real problem.
This PR add using a class name if the object does not have a name.