Show notification when using shortcut to change current selected label to largest used label plus one #6546
Conversation
…l to max value plus one when no change is possible Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
| if layer.selected_label == new_selected_label: | ||
| show_info( | ||
| trans._( | ||
| "Largest label already selected", |
There was a problem hiding this comment.
It sounds misinformation to me. Largest may mean Largest by volume/area.
And here we select first empty labels num.
There was a problem hiding this comment.
Maybe the message could be then something like Maximum label value plus one already set as current selected label or something like that which explains the situation with a more specific/correct wording? Not totally sure what words will describe better that layer.selected_label is already equal to np.max(layer.data) + 1 🤔
There was a problem hiding this comment.
This proposition is much better.
There was a problem hiding this comment.
Yeah it's tricky.
Maximum label value plus one already set as current selected label isn't exactly intuitive either.
maybe highest unused label?
There was a problem hiding this comment.
So something like Highest unused label already set as current selected label?
There was a problem hiding this comment.
In the end we need a message -- notification -- that is targeted at a user painting labels and is clear as to why seemingly nothing happened when they pushed the keybind.
There was a problem hiding this comment.
Maybe something like Current selected label is not being used. You will need to use it to be able to set the current select label to the next label available ? Kind of wordy but maybe can sound like more aimed to an end user which is unaware of implementation details but still wants to increase the current selected label? Could it even be worthy to mention in the notification that to increase the label regardless of it being used you can use the = shortcut?
Edit - The message with the Increase the currently selected label by one shortcut mention could be something like:
Current selected label is not being used. You will need to first use it to be able to set the current select label to the next value available.
To use the next label available regardles of it being used, please check the Increase the currently selected label by one keybinding (=)
There was a problem hiding this comment.
What do you think about structuring the message in that way @Czaki ?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6546 +/- ##
==========================================
- Coverage 92.29% 92.25% -0.05%
==========================================
Files 605 605
Lines 54088 54091 +3
==========================================
- Hits 49923 49901 -22
- Misses 4165 4190 +25 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
|
This PR will may generate conflict with #6548, where, because of typing, I add if guard to allow use only this action is a NumPy array (As it is a whole data scan). This is only a note, I do not thnk that it will require any action. |
psobolewskiPhD
added
the
ready to merge
|
Just FYI, I think the plan is to merge stuff once 0.4.19 is released, to minimize cherry pick issues. |
|
@Czaki we in the clear to merge this? Re: your comment above |
psobolewskiPhD
removed
the
ready to merge
References and relevant issues
Closes #6517
Description
Add showing a notification when the shortcut to set current selected label to largest used label plus one can't change the label value since it is already the largest used label plus one.
A preview: