Do not require triangle on macos arm #6603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6603 +/- ##
==========================================
- Coverage 92.27% 92.22% -0.05%
==========================================
Files 603 603
Lines 53902 53902
==========================================
- Hits 49737 49711 -26
- Misses 4165 4191 +26 ☔ View full report in Codecov by Sentry. |
psobolewskiPhD
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Looks good and works.
❯ pip install ".[all]"
...
❯ pip show numba
Name: numba
Version: 0.58.1
Summary: compiling Python code using LLVM
Home-page: https://numba.pydata.org
Author:
Author-email:
License: BSD
Location: /Users/sobolp/micromamba/envs/napari-dev-t/lib/python3.11/site-packages
Requires: llvmlite, numpy
Required-by:
~/Documents/dev/napari macos_trinage_non_require Py (napari-dev-t) ············
❯ pip show triangle
WARNING: Package(s) not found: triangle
psobolewskiPhD
added
the
ready to merge
|
Here's the triangle PR so that it's easier to check if this can be dropped in the future. |
jni
approved these changes
Jan 20, 2024
|
I think this is important and uncontroversial — thanks @Czaki for the platform-specific solution which minimises the impact! — so I'm going to merge straight away. I think this makes the 0.4.19 release relatively urgent. Hopefully we can push it out next week. 🤞 |
Czaki
added a commit
that referenced
this pull request
Jan 21, 2024
# References and relevant issues Reported on zulip https://napari.zulipchat.com/#narrow/stream/212875-general/topic/installing.20napari.5Ball.5D.2C.20.5Boptional.5D.20etc.2E.20on.20arm64.20macOS/near/416802211 # Description As triangles do not have macOS arm64 wheels, then trying to install napari with `all` extras on macOS arm64 will fail. This PR removes the triangle from optional dependencies for the arm64 platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
Reported on zulip https://napari.zulipchat.com/#narrow/stream/212875-general/topic/installing.20napari.5Ball.5D.2C.20.5Boptional.5D.20etc.2E.20on.20arm64.20macOS/near/416802211
Description
As triangles do not have macOS arm64 wheels, then trying to install napari with
allextras on macOS arm64 will fail.This PR removes the triangle from optional dependencies for the arm64 platform.