Ignore pandas pyarrow warning #6609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6609 +/- ##
==========================================
- Coverage 92.27% 92.22% -0.05%
==========================================
Files 603 603
Lines 53902 53933 +31
==========================================
+ Hits 49736 49742 +6
- Misses 4166 4191 +25 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Co-authored-by: Lorenzo Gaifas <brisvag@gmail.com>
|
Can you explain the new syntax here for posterity? |
|
This PR is using |
brisvag
approved these changes
Jan 22, 2024
brisvag
added
the
ready to merge
Czaki
removed
the
ready to merge
Czaki
added a commit
that referenced
this pull request
Jan 23, 2024
# Description The #6608 shows that new pandas warning crash our tests. ``` /tmp/.tox/py39-linux-pyqt5/lib/python3.9/site-packages/_pytest/assertion/rewrite.py:186: in exec_module exec(co, module.__dict__) napari/layers/base/base.py:28: in <module> from napari.layers.utils.layer_utils import ( <frozen importlib._bootstrap>:1007: in _find_and_load ??? <frozen importlib._bootstrap>:986: in _find_and_load_unlocked ??? <frozen importlib._bootstrap>:680: in _load_unlocked ??? /tmp/.tox/py39-linux-pyqt5/lib/python3.9/site-packages/_pytest/assertion/rewrite.py:186: in exec_module exec(co, module.__dict__) napari/layers/utils/layer_utils.py:10: in <module> import pandas as pd /tmp/.tox/py39-linux-pyqt5/lib/python3.9/site-packages/pandas/__init__.py:221: in <module> warnings.warn( E DeprecationWarning: E Pyarrow will become a required dependency of pandas in the next major release of pandas (pandas 3.0), E (to allow more performant data types, such as the Arrow string type, and better interoperability with other libraries) E but was not found to be installed on your system. E If this would cause problems for you, E please provide us feedback at pandas-dev/pandas#54466 ``` This PR adds filter warnings to prevent this failure. Because warnings start with an empty line, this fix is fragile and heavily depends on the order of imports. Pull request to fix warning message in pandas pandas-dev/pandas#57003 cPython issue: python/cpython#114426 This PR also fixes usage of chained assignment. --------- Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com> Co-authored-by: Lorenzo Gaifas <brisvag@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The #6608 shows that new pandas warning crash our tests.
This PR adds filter warnings to prevent this failure. Because warnings start with an empty line, this fix is fragile and heavily depends on the order of imports.
Pull request to fix warning message in pandas
pandas-dev/pandas#57003
cPython issue:
python/cpython#114426
This PR also fixes usage of chained assignment.