Fixing data_setitem function of label layer #6618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…value is an array and there are unchanged values in the indices.
for more information, see https://pre-commit.ci
…to data_setitem_fix
|
Thanks for spotting the bug and providing PR with a fix for it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6618 +/- ##
==========================================
+ Coverage 92.06% 92.24% +0.18%
==========================================
Files 604 604
Lines 53999 54001 +2
==========================================
+ Hits 49713 49814 +101
+ Misses 4286 4187 -99 ☔ View full report in Codecov by Sentry. |
|
Nice spot. Note In [4]: isinstance(np.arange(10), Sequence)
Out[4]: False |
Czaki
approved these changes
Jan 27, 2024
Czaki
changed the title
Czaki
pushed a commit
that referenced
this pull request
Jan 27, 2024
Labels layer bug fix. Adapting the test now # References and relevant issues This PR closes an new issue that hasn't been noticed yet. # Description This fixes a bug. The following error arises if the "value" input is an array and there are unchanged values in the indices. *** ValueError: shape mismatch: value array of shape (855416,) could not be broadcast to indexing result of shape (88060,) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Czaki
removed
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels layer bug fix. Adapting the test now
References and relevant issues
This PR closes an new issue that hasn't been noticed yet.
Description
This fixes a bug. The following error arises if the "value" input is an array and there are unchanged values in the indices.
*** ValueError: shape mismatch: value array of shape (855416,) could not be broadcast to indexing result of shape (88060,)