Fix points selection #6621
Merged
Fix points selection #6621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6621 +/- ##
==========================================
+ Coverage 92.06% 92.24% +0.18%
==========================================
Files 604 604
Lines 53999 53999
==========================================
+ Hits 49713 49812 +99
+ Misses 4286 4187 -99 ☔ View full report in Codecov by Sentry. |
psobolewskiPhD
approved these changes
Jan 25, 2024
If I correctly understand upstream code, then the fixed version will be equivalent for this code. So the question is which is more readable. |
psobolewskiPhD
removed
the
ready to merge
Czaki
added a commit
that referenced
this pull request
Jan 27, 2024
# References and relevant issues closes #6620 # Description It looks like there is a bug in psygnal selection that copied version of selection is sharing inner set with base one. This PR fixes it. But I will go into direction to fix it also in base.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
closes #6620
Description
It looks like there is a bug in psygnal selection that copied version of selection is sharing inner set with base one. This PR fixes it. But I will go into direction to fix it also in base.