Remove scaling of highlight width, fix showing shapes for uneven coordinates

[Czaki]

References and relevant issues

This PR is created as result of debug #6627 (comment)
As 0.4.19 branch has fewer problems than #6628 is created for 0.4.19.

Description

Fix logic for selecting of visible shapes based on idea from #2289. It is lucky that we do not hit this earlier.

Removes scaling of width of markers border (this is same like in #6628)

To improve readability, this update ShapesVisual to have named subvisuals.

[brisvag]

Fix logic for selecting of visible shapes based on idea from #2289. It is lucky that we do not hi this earlier.

Ahhh! Nice! We did hit this somewhere in zulip a few days ago, it's great you found the issue. Let's get this in asap!

[psobolewskiPhD]

The script from the issue gives me something strange:

But if I hit Home and scroll to the right slice, I see the shape and can interact with it just fine.

[Czaki]

@psobolewskiPhD When I merge main into this branch, it looks fixed

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (63c145f) 92.29% compared to head (8b21f98) 92.25%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6629      +/-   ##
==========================================
- Coverage   92.29%   92.25%   -0.05%     
==========================================
  Files         605      605              
  Lines       54077    54092      +15     
==========================================
- Hits        49912    49902      -10     
- Misses       4165     4190      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[psobolewskiPhD]

If I add viewer.reset_view() after the scale setting for loop then everything is gucci.

[Czaki]

If I add viewer.reset_view() after the scale setting for loop then everything is gucci.

Yes. I found such a line in my script instance. I will take a look at what happens here.