Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename 'publisher' field to 'author' #39

Closed
nclack opened this issue Nov 25, 2021 · 0 comments · Fixed by #40
Closed

rename 'publisher' field to 'author' #39

nclack opened this issue Nov 25, 2021 · 0 comments · Fixed by #40
Assignees
@nclack

Comments

@nclack
Copy link
Collaborator

nclack commented Nov 25, 2021

Originally, I think we we're going to use this to help distinguish plugins that had similar names. But if we end up requiring plugin name is a python package name (see #37) then that's not necessary.

We've ended up using this more as a list of authors. When missing it's populating this from the Author field of the package metadata when it's missing.
@nclack nclack self-assigned this Nov 25, 2021
nclack added a commit to nclack/npe2 that referenced this issue Nov 25, 2021
@nclack
Change 'publisher' to 'authors' (napari#39)
1da7bce
@nclack nclack mentioned this issue Nov 25, 2021
Merged
tlambert03 added a commit that referenced this issue Nov 30, 2021
@nclack @tlambert03
Change 'publisher' to 'author' (#39) (#40)
6227387 
* Change 'publisher' to 'authors' (#39)

* Update npe2/_plugin_manager.py

* Update npe2/_from_npe1.py

Co-authored-by: Talley Lambert <talley.lambert@gmail.com>

* Update npe2/manifest/schema.py

Co-authored-by: Talley Lambert <talley.lambert@gmail.com>

Co-authored-by: Talley Lambert <talley.lambert@gmail.com>
tlambert03 added a commit that referenced this issue Nov 30, 2021
@nclack @tlambert03
Cleanup manifest (#38)
948fee8 
* Some cleanup

* Some more cleanup

* Change 'publisher' to 'authors' (#39)

* Update npe2/_plugin_manager.py

* Update npe2/_from_npe1.py

Co-authored-by: Talley Lambert <talley.lambert@gmail.com>

* Update npe2/manifest/schema.py

Co-authored-by: Talley Lambert <talley.lambert@gmail.com>

* Add back some comments

* fix test

* fix test

* add back license field (#17)

* add back license field try2 (#17)

Co-authored-by: Talley Lambert <talley.lambert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nclack nclack

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change 'publisher' to 'author' (#39) nclack/npe2
1 participant
@nclack