Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ci to test all plugins on PR label #132

Closed
wants to merge 20 commits into from
Closed

Add ci to test all plugins on PR label #132

wants to merge 20 commits into from

Conversation

tlambert03
Copy link
Collaborator

@tlambert03 tlambert03 commented Mar 16, 2022 •
edited
Loading

This adds a new CI file that will run tests declared in tests/test_all_plugins.py on every known plugin. Need to iterate a few times here to check if it's working

(this includes #124, for the sake of testing ... but that will be either merged before this, or removed before merge here)

@tlambert03 tlambert03 added the test-all-plugins use to trigger CI tests on all plugins label Mar 16, 2022
@codecov
Copy link

codecov bot commented Mar 16, 2022 •
edited
Loading

Codecov Report

Merging #132 (0135b22) into main (6f884cf) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #132   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         1715      1715           
=========================================
  Hits          1715      1715

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f884cf...0135b22. Read the comment docs.

@tlambert03 tlambert03 mentioned this pull request Mar 16, 2022
Merged
@tlambert03 tlambert03 closed this Mar 16, 2022
@tlambert03 tlambert03 reopened this Mar 16, 2022
@tlambert03 tlambert03 added test-all-plugins use to trigger CI tests on all plugins and removed test-all-plugins use to trigger CI tests on all plugins labels Mar 17, 2022
@tlambert03 tlambert03 added test-all-plugins use to trigger CI tests on all plugins and removed test-all-plugins use to trigger CI tests on all plugins labels Mar 17, 2022
@tlambert03 tlambert03 added test-all-plugins use to trigger CI tests on all plugins and removed test-all-plugins use to trigger CI tests on all plugins labels Mar 17, 2022
@tlambert03 tlambert03 added test-all-plugins use to trigger CI tests on all plugins and removed test-all-plugins use to trigger CI tests on all plugins labels Mar 17, 2022
@tlambert03
Copy link
Collaborator Author

just a bit of data from the tests here. 21 out of the 143 plugins tested actually need the __npe1shim__ thing at all. all the rest have direct python_names for all their assets

@tlambert03
Copy link
Collaborator Author

and... the current object recovery behavior in #124 appears to be working for every one of those 21 plugins

@tlambert03 tlambert03 removed the test-all-plugins use to trigger CI tests on all plugins label Mar 24, 2022
@tlambert03 tlambert03 closed this Mar 24, 2022
@tlambert03 tlambert03 reopened this Mar 24, 2022
nclack
nclack reviewed Mar 25, 2022
View reviewed changes
.github/workflows/ci.yml
@@ -43,6 +43,7 @@ jobs:
fail_ci_if_error: true

test_napari:
if: ${{ github.event.label.name != 'test-all-plugins' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this triggers for prs with the test-all-plugins label. Is that right?

nclack
nclack approved these changes Mar 25, 2022
View reviewed changes
Copy link
Collaborator

@nclack nclack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I keep having trouble looking at the reports from the failing plugins (github times out) but this looks good to me.

@nclack
Copy link
Collaborator

nclack commented Apr 5, 2022

should this get merged?

@tlambert03
Copy link
Collaborator Author

no need, this is mostly just for testing...

@tlambert03 tlambert03 closed this May 8, 2022
@tlambert03 tlambert03 mentioned this pull request Jun 13, 2022
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nclack nclack nclack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tlambert03 @nclack