Expose syntax_style

[brisvag]

While working on fixing napari themes (see this zulip conversation) I noticed that some fields that are available in napari are not exposed/tested here: icon was unused, and syntax_style was not exposed. I added them to the specs and description.

Also, I noticed that if you pass wrong/nonexisting keys, npe2 does not complain. Is this intended?

[codecov]

Codecov Report

Merging #261 (f82d5dd) into main (0db5c3e) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #261   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         2806      2807    +1     
=========================================
+ Hits          2806      2807    +1     

Impacted Files	Coverage Δ
npe2/manifest/contributions/_themes.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[tlambert03]

if you pass wrong/nonexisting keys, npe2 does not complain. Is this intended?

Yes, otherwise every new field we add to the schema becomes a breaking change for anyone on an older version of npe2

[brisvag]

Makes sense. It would be nice if the npe2 validate command could tell you that you have keys in your schema that do not exist in the current npe2 version. Would help with debugging!

[brisvag]

I can't tell if this failure is a real bug. Are we missing napari-svg for macos?

[tlambert03]

just an internet problem

[brisvag]

Still failing :/

[tlambert03]

still think it's internet... see this test: https://github.com/napari/npe2/actions/runs/3693708290/jobs/6256673381 where everything passed but codecov

[tlambert03]

see #255

[nclack]

lgtm! Just updated to fix the tests. If they all pass now, I'll look to merge tomorrow.