Fix tests: use npe1 version (0.1.2) of napari-ndtiffs #277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
testfetch_manifest_with_full_install
intest_fetch.py
usesassert isinstance(mf, NPE1Adapter)
fornapari-ndtiffs
:npe2/tests/test_fetch.py
Lines 72 to 78 in d7329b7
Recently, that plugin was updated to use npe2, so as a result the test fails.
See also discussion starting here: #275 (comment)
This PR passes the
version
argument to use version 0.1.2 of the plugin which is npe1. This is the simple fix to keep the test working as it has.However, maybe it's best to just drop that NPE1 assert, because I'm not sure it matters that the plugin is or isn't npe1—there are two specific npe1 shim tests already.
So then here we would only assert the name and contributions.
PS. my OCD wants to fix the name to
test_fetch...
but not sure that's ok? 🤣cc: @tlambert03 @Czaki