code about External Command will never be invoked in arbiterdaemon.py

[andyxning]

code in arbiterdaemon.py line between 774-791 will never be invoked. And the external command FIFO will never be created. This problem is just like #1430.

since the initial value of suppl_socks is None, then the initial invoke about handleRequests is just like handleRequests(timeout) which will be actually sleep timeout seconds and return with elapsed be 0 and ins be []. Thus the code in line 774-791 will never be invoked in the first invoke about handleRequests.

As a consequency, external command FIFO will never be initialized and the FD of external command FIFO will never be added to the suppl_socks variable. Thus It is wrong.

RELATED INFO: why pipe does not work with select as expected

If you agree with me, then i can make a Pull Request with both the two issues fixed.

[Seb-Solon]

This seems legit to me. I'll try to reproduce the behavior. I guess the named_pipe related is in the module and so this code is not used.