Update display validation, a display is now valid when it has active …

…bound information
napframework · Jun 7, 2022 · 35b9f6d · 35b9f6d
1 parent fcd3910
commit 35b9f6d
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 11 deletions.
diff --git a/modules/naprender/src/renderservice.cpp b/modules/naprender/src/renderservice.cpp
@@ -2445,10 +2445,9 @@ namespace nap
 	nap::Display::Display(int index) : mIndex(index)
 	{
 		assert(index < SDL::getDisplayCount());
-		int dr = SDL::getDisplayDPI(index, &mDDPI, &mHDPI, &mVDPI);
-		bool name = SDL::getDisplayName(index, mName);
-		int br = SDL::getDisplayBounds(index, mMin, mMax);
-		mValid = (br == 0);
+		SDL::getDisplayDPI(index, &mDDPI, &mHDPI, &mVDPI);
+		SDL::getDisplayName(index, mName);
+		mValid = SDL::getDisplayBounds(index, mMin, mMax) == 0;
 	}
 
 

diff --git a/modules/naprender/src/renderservice.h b/modules/naprender/src/renderservice.h
@@ -138,8 +138,7 @@ namespace nap
 	{
 	public:
 		/**
-		 * Extracts display information.
-		 * Index must be >= 0 && < SDL::getDisplayCount()
+		 * Extracts display information. Index must be >= 0 && < SDL::getDisplayCount()
 		 * @param index display index
 		 */
 		Display(int index);
@@ -150,22 +149,26 @@ namespace nap
 		int getIndex() const { return mIndex; }
 
 		/**
-		 * @return diagonal dpi
+		 * Returns diagonal dots per inch. 0 if diagonal DPI not available. 
+		 * @return diagonal dots per inch. 0 if diagonal DPI not available.
 		 */
 		float getDiagonalDPI() const { return mDDPI; }
 
 		/**
-		 * @return horizontal dpi
+		 * Returns horizontal dots per inch. 0 if horizontal DPI not available. 
+		 * @return horizontal dots per inch. 0 if horizontal DPI not available. 
 		 */
 		float getHorizontalDPI() const { return mHDPI; }
 
 		/**
-		 * @return vertical dpi
+		 * Returns vertical dots per inch. 0 if vertical DPI not available.   
+		 * @return vertical dots per inch. 0 if vertical DPI not available.
 		 */
 		float getVerticalDPI() const { return mVDPI; }
 
 		/**
-		 * @return display name
+		 * Returns display name, empty if not available. 
+		 * @return display name, empty if not available. 
 		 */
 		const std::string& getName() const { return mName; }
 
@@ -185,7 +188,8 @@ namespace nap
 		math::Rect getBounds() const;
 
 		/**
-		 * @return if display information was extracted successfully on construction
+		 * Returns if this display has valid bounds.
+		 * @return if this display has valid bounds.
 		 */
 		bool isValid() const { return mValid; }