remove double binding changed callback in numeric binding instance

napframework · Nov 2, 2022 · d9fae45 · d9fae45
1 parent ef922fe
commit d9fae45
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/modules/naprender/src/bufferbindinginstance.h b/modules/naprender/src/bufferbindinginstance.h
@@ -260,7 +260,6 @@ namespace nap
 
 	protected:
 		const ShaderVariableValueArrayDeclaration*			mDeclaration;
-		BufferBindingChangedCallback						mBindingChangedCallback;
 	};
 
 
@@ -298,7 +297,7 @@ namespace nap
 		 * Updates thebuffer from a resource.
 		 * @param resource resource to set buffer from.
 		 */
-		void setBuffer(const TypedBufferBindingNumeric<T>& resource)			{ BufferBindingInstance::mBuffer = resource.mBuffer.get(); }
+		void setBuffer(const TypedBufferBindingNumeric<T>& resource);
 
 		/**
 		 * @return buffer
@@ -344,4 +343,12 @@ namespace nap
 		BufferBindingInstance::mBuffer = &buffer;
 		raiseChanged();
 	}
+
+	template<class T>
+	void TypedBufferBindingNumericInstance<T>::setBuffer(const TypedBufferBindingNumeric<T>& resource)
+	{
+		assert(resource.mBuffer.getSize() == mDeclaration->mSize);
+		BufferBindingInstance::mBuffer = resource.mBuffer.get();
+		raiseChanged();
+	}
 }