Skip to content

Commit

Permalink
fix(cli): C_FLAGS should be CFLAGS
Browse files Browse the repository at this point in the history
  • Loading branch information
@Brooooooklyn
Brooooooklyn committed Dec 6, 2023
1 parent 6d56595 commit 266d1f2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cli/src/api/build.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ class Builder {
(process.env.TARGET_CC === 'clang' || !process.env.TARGET_CC)) ||
process.env.TARGET_CC === 'clang'
) {
this.envs.C_FLAGS = `--sysroot=${this.envs.TARGET_SYSROOT}`
this.envs.CFLAGS = `--sysroot=${this.envs.TARGET_SYSROOT}`
}
} catch (e) {
debug.warn('Pick cross toolchain failed', e as Error)
Expand Down

1 comment on commit 266d1f2

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 266d1f2 Previous: 6d56595 Ratio
noop#napi-rs 85160724 ops/sec (±1.7%) 87582138 ops/sec (±1.3%) 1.03
noop#JavaScript 817834221 ops/sec (±0.12%) 842601063 ops/sec (±0.49%) 1.03
Plus number#napi-rs 23862540 ops/sec (±0.21%) 25033010 ops/sec (±0.44%) 1.05
Plus number#JavaScript 816836415 ops/sec (±0.15%) 839377656 ops/sec (±0.45%) 1.03
Create buffer#napi-rs 671283 ops/sec (±11.9%) 660948 ops/sec (±12.13%) 0.98
Create buffer#JavaScript 3727924 ops/sec (±2.71%) 3490317 ops/sec (±3.02%) 0.94
createArray#createArrayJson 54374 ops/sec (±0.48%) 55287 ops/sec (±0.47%) 1.02
createArray#create array for loop 10448 ops/sec (±0.37%) 10556 ops/sec (±0.75%) 1.01
createArray#create array with serde trait 10433 ops/sec (±0.22%) 10642 ops/sec (±0.58%) 1.02
getArrayFromJs#get array from json string 24023 ops/sec (±0.21%) 24200 ops/sec (±1.03%) 1.01
getArrayFromJs#get array from serde 11845 ops/sec (±0.58%) 11895 ops/sec (±0.71%) 1.00
getArrayFromJs#get array with for loop 16795 ops/sec (±0.35%) 17315 ops/sec (±0.63%) 1.03
Get Set property#Get Set from native#u32 607423 ops/sec (±7.93%) 573095 ops/sec (±12.85%) 0.94
Get Set property#Get Set from JavaScript#u32 543399 ops/sec (±2.5%) 563307 ops/sec (±2.21%) 1.04
Get Set property#Get Set from native#string 575390 ops/sec (±1.86%) 566562 ops/sec (±11.4%) 0.98
Get Set property#Get Set from JavaScript#string 504011 ops/sec (±1.88%) 506414 ops/sec (±2.1%) 1.00
Async task#spawn task 26728 ops/sec (±0.3%) 27446 ops/sec (±0.92%) 1.03
Async task#ThreadSafeFunction 9134 ops/sec (±1.26%) 9397 ops/sec (±1.39%) 1.03
Async task#Tokio future to Promise 33005 ops/sec (±1.3%) 33806 ops/sec (±0.77%) 1.02
Query#query * 100 3879 ops/sec (±0.5%) 4078 ops/sec (±1.36%) 1.05
Query#query * 1 26859 ops/sec (±1.64%) 28831 ops/sec (±1.26%) 1.07

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.