Skip to content

Commit

Permalink
fix(cli): fix random node process got killed issue
Browse files Browse the repository at this point in the history
  • Loading branch information
forehalo committed Jan 7, 2021
1 parent 0c041ee commit 58d4634
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
11 changes: 6 additions & 5 deletions cli/src/build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import toml from 'toml'
import { getNapiConfig } from './consts'
import { debugFactory } from './debug'
import { getDefaultTargetTriple, parseTriple } from './parse-triple'
import { existsAsync, readFileAsync, writeFileAsync } from './utils'
import { copyFileAsync, existsAsync, readFileAsync, unlinkAsync } from './utils'

const debug = debugFactory('build')

Expand Down Expand Up @@ -173,13 +173,14 @@ export class BuildCommand extends Command {
}

const sourcePath = join(dir, 'target', targetDir, `${dylibName}${libExt}`)
debug(`Read [${chalk.yellowBright(sourcePath)}] content`)

const dylibContent = await readFileAsync(sourcePath)
if (await existsAsync(distModulePath)) {
debug(`remove old binary [${chalk.yellowBright(sourcePath)}]`)
await unlinkAsync(distModulePath)
}

debug(`Write binary content to [${chalk.yellowBright(distModulePath)}]`)

await writeFileAsync(distModulePath, dylibContent)
await copyFileAsync(sourcePath, distModulePath)
}
}

Expand Down
4 changes: 3 additions & 1 deletion cli/src/utils.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { readFile, writeFile, exists } from 'fs'
import { readFile, writeFile, exists, copyFile, unlink } from 'fs'
import { promisify } from 'util'

export const readFileAsync = promisify(readFile)
export const writeFileAsync = promisify(writeFile)
export const existsAsync = promisify(exists)
export const unlinkAsync = promisify(unlink)
export const copyFileAsync = promisify(copyFile)

0 comments on commit 58d4634

Please sign in to comment.