Skip to content

Commit

Permalink
fix(cli): set RANLIB while building android targets
Browse files Browse the repository at this point in the history
  • Loading branch information
Brooooooklyn committed Aug 16, 2023
1 parent 00ac5b1 commit 5d0240e
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions cli/src/api/build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,7 @@ class Builder {
CC: `${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/${hostPlatform}-x86_64/bin/${targetArch}-linux-${targetPlatform}-clang`,
CXX: `${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/${hostPlatform}-x86_64/bin/${targetArch}-linux-${targetPlatform}-clang++`,
AR: `${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/${hostPlatform}-x86_64/bin/llvm-ar`,
RANLIB: `${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/${hostPlatform}-x86_64/bin/llvm-ranlib`,
ANDROID_NDK: ANDROID_NDK_LATEST_HOME,
PATH: `${ANDROID_NDK_LATEST_HOME}/toolchains/llvm/prebuilt/${hostPlatform}-x86_64/bin:${process.env.PATH}`,
})
Expand Down

1 comment on commit 5d0240e

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 5d0240e Previous: 00ac5b1 Ratio
noop#napi-rs 60823689 ops/sec (±0.79%) 51964358 ops/sec (±0.63%) 0.85
noop#JavaScript 711098617 ops/sec (±0.19%) 771023644 ops/sec (±0.79%) 1.08
Plus number#napi-rs 18430911 ops/sec (±0.76%) 14882761 ops/sec (±1.36%) 0.81
Plus number#JavaScript 708607723 ops/sec (±0.25%) 757787606 ops/sec (±0.79%) 1.07
Create buffer#napi-rs 347750 ops/sec (±9.35%) 302588 ops/sec (±10.77%) 0.87
Create buffer#JavaScript 1942191 ops/sec (±4.05%) 1449855 ops/sec (±6.99%) 0.75
createArray#createArrayJson 35907 ops/sec (±0.27%) 35083 ops/sec (±0.62%) 0.98
createArray#create array for loop 7033 ops/sec (±0.15%) 6043 ops/sec (±0.82%) 0.86
createArray#create array with serde trait 7008 ops/sec (±0.11%) 6083 ops/sec (±0.71%) 0.87
getArrayFromJs#get array from json string 16425 ops/sec (±0.22%) 14136 ops/sec (±0.99%) 0.86
getArrayFromJs#get array from serde 9648 ops/sec (±0.06%) 7853 ops/sec (±0.96%) 0.81
getArrayFromJs#get array with for loop 12029 ops/sec (±0.26%) 10013 ops/sec (±0.73%) 0.83
Get Set property#Get Set from native#u32 442835 ops/sec (±8.34%) 399447 ops/sec (±7.03%) 0.90
Get Set property#Get Set from JavaScript#u32 395393 ops/sec (±9.5%) 325023 ops/sec (±10.76%) 0.82
Get Set property#Get Set from native#string 390569 ops/sec (±16.07%) 357713 ops/sec (±3.77%) 0.92
Get Set property#Get Set from JavaScript#string 369078 ops/sec (±3.29%) 288580 ops/sec (±18.85%) 0.78
Async task#spawn task 36207 ops/sec (±0.7%) 28614 ops/sec (±2.23%) 0.79
Async task#ThreadSafeFunction 5394 ops/sec (±5.11%) 3866 ops/sec (±5.67%) 0.72
Async task#Tokio future to Promise 31736 ops/sec (±0.77%) 26807 ops/sec (±2.2%) 0.84
Query#query * 100 1661 ops/sec (±2.12%) 1317 ops/sec (±2.42%) 0.79
Query#query * 1 32119 ops/sec (±0.67%) 22924 ops/sec (±1.37%) 0.71

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.