Skip to content

Commit

Permalink
fix(cli): exclude node_modules in artifacts command
Browse files Browse the repository at this point in the history
  • Loading branch information
Brooooooklyn committed Dec 29, 2023
1 parent 43a080d commit 67743b1
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion cli/src/api/artifacts.ts
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ async function collectNodeBinaries(root: string) {

const dirs = files.filter((file) => file.isDirectory())
for (const dir of dirs) {
nodeBinaries.push(...(await collectNodeBinaries(join(root, dir.name))))
if (dir.name !== 'node_modules') {
nodeBinaries.push(...(await collectNodeBinaries(join(root, dir.name))))
}
}
return nodeBinaries
}

1 comment on commit 67743b1

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 67743b1 Previous: 43a080d Ratio
noop#napi-rs 86764559 ops/sec (±0.31%) 86838649 ops/sec (±0.28%) 1.00
noop#JavaScript 821669325 ops/sec (±0.26%) 822245307 ops/sec (±0.28%) 1.00
Plus number#napi-rs 19638841 ops/sec (±0.14%) 19542898 ops/sec (±0.15%) 1.00
Plus number#JavaScript 822318605 ops/sec (±0.08%) 822919138 ops/sec (±0.09%) 1.00
Create buffer#napi-rs 655376 ops/sec (±12.83%) 682641 ops/sec (±12.33%) 1.04
Create buffer#JavaScript 3730426 ops/sec (±2.62%) 3274990 ops/sec (±9.05%) 0.88
createArray#createArrayJson 54782 ops/sec (±0.35%) 55111 ops/sec (±0.59%) 1.01
createArray#create array for loop 10046 ops/sec (±0.46%) 10090 ops/sec (±0.22%) 1.00
createArray#create array with serde trait 10001 ops/sec (±0.48%) 10027 ops/sec (±0.5%) 1.00
getArrayFromJs#get array from json string 23518 ops/sec (±0.42%) 23964 ops/sec (±0.43%) 1.02
getArrayFromJs#get array from serde 13517 ops/sec (±0.58%) 13466 ops/sec (±0.43%) 1.00
getArrayFromJs#get array with for loop 16696 ops/sec (±0.21%) 16733 ops/sec (±0.29%) 1.00
Get Set property#Get Set from native#u32 584583 ops/sec (±12.83%) 609125 ops/sec (±11.02%) 1.04
Get Set property#Get Set from JavaScript#u32 535274 ops/sec (±2.75%) 536367 ops/sec (±2.39%) 1.00
Get Set property#Get Set from native#string 555650 ops/sec (±11.08%) 557917 ops/sec (±11.32%) 1.00
Get Set property#Get Set from JavaScript#string 514472 ops/sec (±1.99%) 523231 ops/sec (±1.93%) 1.02
Async task#spawn task 26874 ops/sec (±0.61%) 26986 ops/sec (±0.3%) 1.00
Async task#ThreadSafeFunction 9369 ops/sec (±0.72%) 9351 ops/sec (±0.77%) 1.00
Async task#Tokio future to Promise 33205 ops/sec (±0.92%) 32123 ops/sec (±1.06%) 0.97
Query#query * 100 3937 ops/sec (±0.51%) 3961 ops/sec (±0.37%) 1.01
Query#query * 1 28929 ops/sec (±1.51%) 27542 ops/sec (±1.5%) 0.95

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.