fix(cli): enum TypeScript type should be const enum

napi-rs · Dec 9, 2021 · f4b0a2e · f4b0a2e
1 parent 0723e15
commit f4b0a2e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/cli/src/build.ts b/cli/src/build.ts
@@ -394,7 +394,8 @@ export class ExternalObject<T> {
             idents.push(def.name)
           }
           dts +=
-            indentLines(`${def.js_doc}export enum ${def.name} {`, nest) + '\n'
+            indentLines(`${def.js_doc}export const enum ${def.name} {`, nest) +
+            '\n'
           dts += indentLines(def.def, nest + 2) + '\n'
           dts += indentLines(`}`, nest) + '\n'
           break

diff --git a/examples/napi/index.d.ts b/examples/napi/index.d.ts
@@ -28,7 +28,7 @@ export interface Obj {
 }
 export function either4(input: string | number | boolean | Obj): number
 /** default enum values are continuos i32s start from 0 */
-export enum Kind {
+export const enum Kind {
   /** Barks */
   Dog = 0,
   /** Kills birds */
@@ -37,7 +37,7 @@ export enum Kind {
   Duck = 2
 }
 /** You could break the step and for an new continuous value. */
-export enum CustomNumEnum {
+export const enum CustomNumEnum {
   One = 1,
   Two = 2,
   Three = 3,
@@ -68,7 +68,7 @@ export interface AllOptionalObject {
   age?: number | undefined | null
 }
 export function receiveAllOptionalObject(obj?: AllOptionalObject | undefined | null): void
-export enum ALIAS {
+export const enum ALIAS {
   A = 0,
   B = 1
 }