Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Env::throw_error is unsafe if msg contains 0s #300

Closed
adumbidiot opened this issue Nov 14, 2020 · 0 comments · Fixed by #309
Closed

Env::throw_error is unsafe if msg contains 0s #300

adumbidiot opened this issue Nov 14, 2020 · 0 comments · Fixed by #309
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@adumbidiot
Copy link
Collaborator

Env::throw_error is unsafe if msg contains 0s. We do no checks elsewhere to ensure that msg contains no 0s, so this is not safe.
@Brooooooklyn Brooooooklyn added bug Something isn't working good first issue Good for newcomers labels Nov 16, 2020
@Brooooooklyn Brooooooklyn mentioned this issue Nov 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(napi): CString issues napi-rs/napi-rs
2 participants
@Brooooooklyn @adumbidiot