Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(napi): CString issues #309

Merged
merged 2 commits into from
Nov 19, 2020
Merged

fix(napi): CString issues #309

merged 2 commits into from
Nov 19, 2020

Conversation

Brooooooklyn
Copy link
Sponsor Member

@Brooooooklyn Brooooooklyn commented Nov 18, 2020

Close #300
Close #299

@Brooooooklyn Brooooooklyn marked this pull request as ready for review November 19, 2020 16:43
@Brooooooklyn Brooooooklyn merged commit 89d507d into master Nov 19, 2020
@Brooooooklyn Brooooooklyn deleted the cstring-issues branch November 19, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Env::throw_error is unsafe if msg contains 0s NapiValue trait functions are unsafe
1 participant