Call sync functions within tokio runtime #1242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
napi
will only usetokio
if the function being called is declaredasync
. This is a problem for users ofnapi
because it means that we only have atokio
runtime in some contexts. This makes it difficult to predict if our nonasync
code which is dependent on thetokio
runtime will work or not.In this PR I have
napi
enter thetokio
runtime before calling synchronous functions, unless thetokio_rt
feature is disabled, in which case it will just call the synchronous function.