fix(napi): free buffer in current thread if env is available #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brooooooklyn
force-pushed
the
double-free-buffer
branch
2 times, most recently
from
372f947
to
7f32d6d
Compare
Brooooooklyn
force-pushed
the
double-free-buffer
branch
from
7f32d6d
to
db8df66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can confirm the double free error no longer occurred after I applied this patch to
@parcel/sourcemapand@parcel/hashwithPARCEL_WORKERS=64 yarn build.The root cause is that
BufferandTypedArrayare not zero overhead, as they bring many boundary condition processing in async context, which is a design issue. I am considering providing&[u8/i8/...]as a parameter to represent pure JavaScriptTypedArray. If in synchronous usage scenarios like@parcel/hashand@parcel/sourcemap, the best option currently is to useJsBufferto avoid unnecessary runtime performance degradation./cc @devongovett