Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(target): add support for riscv64gc-unknown-linux-gnu #1599

Merged
merged 2 commits into from May 26, 2023
Merged

feat(target): add support for riscv64gc-unknown-linux-gnu #1599

merged 2 commits into from May 26, 2023

Conversation

kxxt
Copy link
Contributor

@kxxt kxxt commented May 26, 2023

Add support for riscv64gc-unknown-linux-gnu target.

Build a project with --cross-compile will fail with the following error:

error: linking with `/home/kxxt/.cache/cargo-zigbuild/0.16.2/zigcc-riscv64gc-unknown-linux-gnu.sh` failed: exit status: 1
  |
  = note: LC_ALL="C" PATH=...
  = note: /usr/lib/zig/libc/glibc/sysdeps/riscv/start-2.33.S:48:2: error: unknown directive
           .cfi_label .Ldummy

But linking with riscv64-linux-gnu-gcc works fine.

Brooooooklyn
Brooooooklyn approved these changes May 26, 2023
View reviewed changes
Copy link
Sponsor Member

@Brooooooklyn Brooooooklyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Brooooooklyn Brooooooklyn merged commit ab83d88 into napi-rs:main May 26, 2023
30 of 31 checks passed
@kxxt kxxt mentioned this pull request Nov 25, 2023
Merged
@kxxt kxxt mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brooooooklyn Brooooooklyn Brooooooklyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kxxt @Brooooooklyn